-
Notifications
You must be signed in to change notification settings - Fork 549
Update geomet to latest in requirements.txt #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Triggered a PR build for this, just to make sure there aren't any obvious regressions with the unit/integration tests |
@absurdfarce I'm unable to see the pr-merge output which is on dsinternal.org, but can you share what failed? |
Hey @bschoening, thanks for following up! The failures for that run are all known intermittent test failures that creep up from time to time. I've tried to fix a few of the more obvious ones but my expectation is that most (maybe all?) will go away once we finish the move to pytest. The one thing I do still need to check here is how this behaves with tests.unit.advanced.test_geometry; that test wasn't run for the test configuration powering that Jenkins run. If that test is good I think I'm satisfied there's no API change in this version of geomet. Worth noting that the test_geometry unit test does employ a skipUnless annotation to skip several test cases if geomet isn't installed. |
A quick update: tests.unit.advanced.test_geometry passes locally for me with geomet 1.1 in play. |
I also re-ran tests.integration.advanced.test_geometry against DSE 6.8.30 locally and observed results similar to those reported by Jenkins (i.e. all passed except for two methods on BasicGeometricPointTypeTest which both have unittest.skip annotations in place). At this point I don't have any reason to believe there's a problem with the upgrade here so I'm calling this good. |
Hello. Line 386 in 1798cf7
I've tried to update packages using poetry and it downgraded cassandra-driver version to 3.20.2 from 3.29.1 because it doesn't have any geomet requirements and I have to use geomet==1.1.0 in project.
|
There is an open PR to fix this #1236. |
Geomet 0.3 only officially supports EOL Python versions 2.7 ... 3.7 and has an unnecessary dependency on the python 2 compatibility library 'six'. Upgrading to 1.1.0 resolves this.
This a blocking issue for a Homebrew PR to remove six from the Cassandra package