Skip to content

Nested Digests #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
curran opened this issue Jun 7, 2016 · 3 comments
Closed

Nested Digests #18

curran opened this issue Jun 7, 2016 · 3 comments

Comments

@curran
Copy link
Member

curran commented Jun 7, 2016

Within a reactive function, it should be possible to invoke digest multiple times.

@curran
Copy link
Member Author

curran commented Jun 7, 2016

Necessary for datavis-tech/reactive-vis#14

@curran curran closed this as completed in 90927b7 Jun 7, 2016
@curran
Copy link
Member Author

curran commented Jun 7, 2016

I wonder if the current implementation supports multiple levels of nesting... I'm not sure it does. It wipes out the changed nodes before and after the topological sort and dataflow graph execution, but I wonder if it might be better to use a stack here, pushing and popping the context.

@curran
Copy link
Member Author

curran commented Jun 7, 2016

Added a test for doubly nested digest. It does work in the current implementation. It appears that the computed topological sort serves as a kind of call stack, so I think digests can be nested arbitrarily deeply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant