Skip to content

Check for memory leaks #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
curran opened this issue May 19, 2016 · 2 comments
Closed

Check for memory leaks #7

curran opened this issue May 19, 2016 · 2 comments
Milestone
1.0

Comments

@curran
Copy link
Member

curran commented May 19, 2016

In particular, investigate the case of no output property. Is everything cleaned up in destroy?
@curran curran added this to the 1.0 milestone May 23, 2016
@curran
Copy link
Member Author

curran commented May 24, 2016

Part of reactive-model 1.0 datavis-tech/reactive-model#31

@curran curran mentioned this issue May 25, 2016
Closed
4 tasks
@curran
Copy link
Member Author

curran commented May 25, 2016 •
edited
Loading

There were indeed memory leaks - nodes were not being removed from the graph. #12 This has been fixed.

The case of no output property has no issues, everything is still cleaned up in this case.

@curran curran closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@curran