Skip to content

Clean up nodes on destroy() #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
curran opened this issue May 25, 2016 · 3 comments
Closed
4 tasks done

Clean up nodes on destroy() #12

curran opened this issue May 25, 2016 · 3 comments

Comments

@curran
Copy link
Member

curran commented May 25, 2016

If property nodes have no incoming or outgoing edges in the data flow graph, they should be removed from the graph when a reactive function that references them (as inputs or outputs) is destroy()ed.

To check:

  • inputs with no outgoing edges
  • inputs with no incoming edges
  • output with no outgoing edges
  • output with no incoming edges

When serializing the graph at the last unit test, this is what it looks like now:

{
  "nodes": [
    { "id": "1"  },
    {"id": "2"},
    {"id": "3" },
    ... all the way up to
    {"id": "58" }
  ],
  "links": [
    { "source": "57", "target": 56  },
    { "source": "58", "target": 56 }
  ]
}
@curran
Copy link
Member Author

curran commented May 25, 2016

Necessary for #11

@curran
Copy link
Member Author

curran commented May 25, 2016

Depends on datavis-tech/graph-data-structure#11

@curran
Copy link
Member Author

curran commented May 25, 2016

Required for #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant