Skip to content

refactor: rule optimization #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Sep 7, 2024

Proposed changes

Deactivating a rule in total is quite heavy, we should only take care of specific aspects and probably define things a little bit more granular.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Sep 7, 2024
@mfranzke mfranzke added this to the v0.5.0 milestone Sep 7, 2024
@mfranzke mfranzke self-assigned this Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-rule-optimization

@mfranzke mfranzke removed this from the v0.5.0 milestone Oct 27, 2024
@mfranzke mfranzke requested a review from Copilot March 28, 2025 14:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the rule configuration to optimize how imports are handled, aiming for a more granular approach rather than deactivating rules entirely.

  • Updated the configuration for the "import/extensions" rule to enforce specific behavior for TypeScript files.
  • Retains the existing configuration for other import-related rules.
Comments suppressed due to low confidence (1)

.xo-config.cjs:35

  • Verify that the new configuration for 'import/extensions' does not conflict with 'n/file-extension-in-import'. If both rules are enforcing similar checks, consider consolidating or clarifying their roles to avoid unintended linting errors.
                'import/extensions': [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍄🆙improvement New feature or request
Projects
Status: 🏗 In development
Development

Successfully merging this pull request may close these issues.

2 participants