Skip to content

refactor(selector): not hiding the first option anymore #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Apr 4, 2025

Proposed changes

  • it's inconsistent in between browsers (Safari would still display that option[hidden])
  • it's inconsistent and incorrect for regular select-HTML-elements, as those would actually mark the first option as checked as well, whereas this is actually the selected one (gets transmitted in form submits etc.)
  • In case that somebody would like to use floating labels or placeholder, there should be an option that the users could set to "unselect" all selectable options, or in other words "reset" any other selection. We wouldn't provide this possibility at the moment anyhow.

Resolves #4019

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

it's inconsistent in between browsers and we should only use it for placeholders or floating labels
@mfranzke mfranzke requested a review from nmerget as a code owner April 4, 2025 09:16
@mfranzke mfranzke linked an issue Apr 4, 2025 that may be closed by this pull request
7 tasks
@mfranzke mfranzke self-assigned this Apr 4, 2025
Copy link
Contributor

github-actions bot commented Apr 4, 2025

@mfranzke mfranzke added the 🍄🆙 improvement New feature or request label Apr 4, 2025
@github-actions github-actions bot added the 🧱 components Changes inside components folder label Apr 4, 2025
@mfranzke mfranzke requested review from Copilot and removed request for nmerget April 4, 2025 09:16
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Apr 4, 2025
@mfranzke mfranzke added the 🐛 bug Something isn't working label Apr 4, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • packages/components/src/components/select/select.scss: Language not supported
  • packages/components/src/styles/internal/_form-components.scss: Language not supported

@mfranzke mfranzke added this to the 2.0.0 milestone Apr 4, 2025
@mfranzke mfranzke changed the title refactor: let's not hide the first element in the select anymore refactor(selector): let's not hide the first element in the select anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first element in the select anymore refactor(selector): let's not hide the first element anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first element anymore refactor(selector): let's not hide the first option anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first option anymore refactor(selector): not hiding the first option anymore Apr 4, 2025
@mfranzke mfranzke modified the milestones: 2.0.0, 2.1.0 Apr 15, 2025
@github-actions github-actions bot added the 📦 foundations Changes inside foundations folder label Apr 17, 2025
@github-actions github-actions bot added the 📺 showcases Changes to 1-n showcases label Apr 17, 2025
@github-actions github-actions bot removed 📦 foundations Changes inside foundations folder 📺 showcases Changes to 1-n showcases labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🧱 components Changes inside components folder 🍄🆙 improvement New feature or request
Projects
Status: No status
Status: 🏗 In development
Development

Successfully merging this pull request may close these issues.

DBSelect dropdown checkmark on first element
1 participant