Skip to content

refactor(input): differentiating expected type for min and max #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

refactor(input): differentiating expected type for min and max #4144

wants to merge 9 commits into from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Apr 30, 2025 •
edited
Loading

Proposed changes

types: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/min#syntax

Resolves #4143

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🐛 bug Something isn't working label Apr 30, 2025
@mfranzke mfranzke self-assigned this Apr 30, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner April 30, 2025 15:02
@mfranzke mfranzke linked an issue Apr 30, 2025 that may be closed by this pull request
DBInput: Min and max props with type string results in NaN #4143
Open
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4143-dbinput-min-and-max-props-with-type-string-results-in-nan

@mfranzke mfranzke moved this to 🕋 In progress in UX Engineering Team Backlog Apr 30, 2025
@mfranzke mfranzke moved this from 🕋 In progress to 🏗 In development in UX Engineering Team Backlog Apr 30, 2025
@mfranzke mfranzke requested a review from nmerget May 1, 2025 05:40
@mfranzke mfranzke enabled auto-merge (squash) May 1, 2025 06:51
@mfranzke mfranzke moved this from 🏗 In development to 👀 In review in UX Engineering Team Backlog May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🐛 bug Something isn't working
Projects
UX Engineering Team Backlog
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBInput: Min and max props with type string results in NaN
2 participants
@mfranzke @nmerget