Skip to content

Increased timeout for test #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Increased timeout for test #462

merged 1 commit into from
Apr 23, 2020

Conversation

ellbosch
Copy link
Collaborator

One of our tests has failed multiple times due to timeout.

@ellbosch ellbosch requested a review from pensivebrian April 23, 2020 16:46
pensivebrian
pensivebrian approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@pensivebrian pensivebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but this test shouldn't need to create a database. If you're having name conflicts, consider using temp tables which our bound to the connection, and are automatically dropped when the connection closes.

@ellbosch ellbosch merged commit 69dfe99 into master Apr 23, 2020
@ellbosch ellbosch deleted the ellbosch/fix-test-merge branch April 23, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pensivebrian pensivebrian pensivebrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellbosch @pensivebrian