Browser crashes completely using multiple selectMenu with ie11

[guillaumemach]

Hello all,

I am encountering an issue on all my versions of ie11 (even tried on browserstack to check) with dc.js and selectMenu.

Everytime I try to filter data whith selectMenu, with multiple(true) option, using ie11, the browser crashes completely.

To reproduce easily, just open an ie11 browser, and go to the dc.js selectMenu example page, then try to filter data using the multiple selectMenu (the two on the right). The browser will crash instantly.

Has anyone more info about this ?

Thanks a lot in advance for your help !

[gordonwoodhull]

Hi @gmacherey, thanks for the report.

Sorry but I am unable to reproduce on Windows 10, IE 11.540.15063.0

I also previously put in some special cases for multiple select in IE because it was not behaving according to the standards. So that's one more data point.

I don't know if the automated testing we do on IE11 would trigger this.

I'd first make sure you don't have any extensions which cause this. Maybe test on another machine?

[guillaumemach]

Hi @gordonwoodhull, thanks a lot for your quick reply.

I tried a few different ie11 versions on different windows versions. Here is what I could try so far:

With crash:
latest on windows 7 (see picture one)

latest on windows 8 (see picture two)

No crash on the latest on windows 10 (see picture 3)

And I have experienced the same crash on one of my testing machine running windows7 with latest ie11 such as the one on pictrue 1.

Hope that helps a little bit ;) I cannot get any error since the app crashes, so nothing is logged in the console.

Thanks also for this awesome library

[gordonwoodhull]

I see. Thanks for testing this! I think I have VMs for these end-of-life but still widely used OS.

Can't wait till IE goes away and we can rely on people using Edge!

[guillaumemach]

I fully agree ;)

[vparpoil]

@gordonwoodhull Here is some input for this issue that I found while investigating :
It seems that the redrawAll function called here causes the crash. If you change the call to use renderAll, it solves the issue on IE 11 (of course, this has the effect of removing all the transitions when selecting data...)

I investigated a bit more but wasn't able to find a fix. I hope it helps !

Edit: and just so you know, automated testing does not trigger the crash in IE

[gordonwoodhull]

Thanks @vparpoil! That's really good to know. I wonder if we are missing the right test cases or if for some reason the issue is not triggered by Jasmine.

Sounds like a possible workaround is to only render and not redraw the selectMenu (but allow other charts to redraw as normal). selectMenu does not benefit from redraw anyway.

Could anyone try

menu.redraw = menu.render;

and report if it helps?

[vparpoil]

@gordonwoodhull, thank you for your answer. I added
_chart.redraw = _chart.render; to src/select_menu.js
It does fix the IE crash, but there is an unwanted effect : the Select All option stays selected on IE and Chrome (see print screen)

I actually found a workaround and added a pull request here:
#1338

[gordonwoodhull]

Fixed in 2.1.9