General discussion and update

[kum-deepak]

We can use this for general discussion and status. Please put 'discussion' label on this.

[kum-deepak]

• I am happy with the sunburst chart.
• In input filter - the name does no go well, please suggest a name, with that change, it will be ready from my end.
• In check box menu, I need one more round of code review, I have suspicion of some subtle bugs.
• I will then move onto Add Html legend support #1329
• In parallel look onto using Firefox for automated tests.

[kum-deepak]

Please let me know the PRs that you would like me to work on, i.e., which can not be merged because of poor test coverage.

I will be less available for next 2-3 days, so, my responses in this period will be slower.

[gordonwoodhull]

Thank you, will do!!

[gordonwoodhull]

PRs which look good but need better test coverage:

• GeoChoropleth refactor #719 (as noted, it's a tricky merge, so probably better to port the PR and re-appy Choropleth keep d3.geoAlbers the default projection but deprecate it #1382 than try to rebase it onto 3.0)
• added bullet chart #923 (we should wait to see if there is a new version though)
• Gauge chart #893
• Canvas based scatterPlot implementation #1361

[gordonwoodhull]

If possible, #1365 and #1367 both need tests that fail before the changes are applied, but succeed with the changes.

[kum-deepak]

#1365 has test cases, I will check if these fail with old code and pass with the PR :)

[gordonwoodhull]

Fantastic, those look really thorough. I guess it's just #1367 missing tests; I found it a bit confusing but maybe I didn't stare at it long enough.

[kum-deepak]

Thanks for all your support. I understand the approach with smaller single feature PRs. That will help contributors as well :)

In general the approach you are taking is regarding releases is a proper one. It is good to add new features etc., but what users - barring few courageous ones - are looking more is stability.

I have been going through the code and will make successive refactors, however I feel most of those are better taken after we have split the library into modules (like D3). One implicit target for that release will be to allow other users to use contributed charts easily without waiting for it to be merged into main release.

[kum-deepak]

#1414, #1409, and #1416 are ready for your review.

[kum-deepak]

#1418 and #1417 are also ready.

Please give #1418 priority over others - this has overlapping code for renaming selection.

[gordonwoodhull]

Thanks @kum-deepak! Hope to take a look in the afternoon NYC time.

[gordonwoodhull]

I merged 3.0 into develop/master and deleted the branch.

Unfortunately GitHub closed all the open PRs for that branch when I did that.

I recreated the branch and think I reopened all of the PRs, but lmk if anything is still amiss.

[kum-deepak]

Other than #1408 all seems to be ok. Did you close #1408 on purpose?