Skip to content

fix(type-compiler): set ts compiler options target to es2022 if esnext when resolving global lib files #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcus-sa
Copy link
Contributor

Summary of changes

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@marcus-sa marcus-sa changed the title fix(type-compiler): set ts compiler options target to es2022 if higher than es20222 when resolving global lib files fix(type-compiler): set ts compiler options target to es2022 if higher than es2022 when resolving global lib files Nov 30, 2023
@marcus-sa marcus-sa changed the title fix(type-compiler): set ts compiler options target to es2022 if higher than es2022 when resolving global lib files fix(type-compiler): set ts compiler options target to es2022 if esnext when resolving global lib files Nov 30, 2023
@marcus-sa marcus-sa force-pushed the fix/unsupported-esnext-tsconfig-target branch from 1ae116c to ed5a482 Compare November 30, 2023 09:37
…r than es20222 when resolving global lib files
@marcus-sa marcus-sa force-pushed the fix/unsupported-esnext-tsconfig-target branch from ed5a482 to 4c65380 Compare November 30, 2023 09:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f20700) 77.74% compared to head (43788be) 77.70%.
Report is 1 commits behind head on master.

❗ Current head 43788be differs from pull request most recent head 4c65380. Consider uploading reports for the commit 4c65380 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   77.74%   77.70%   -0.04%     
==========================================
  Files         188      188              
  Lines       20025    20025              
  Branches     5183     5183              
==========================================
- Hits        15568    15560       -8     
- Misses       4457     4465       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcj marcj merged commit 29a1a17 into deepkit:master Dec 5, 2023
@marcj
Copy link
Member

marcj commented Dec 5, 2023

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants