Skip to content

chore: add prettier, commitlint & lefthook #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

marcus-sa
Copy link
Contributor

@marcus-sa marcus-sa commented Dec 12, 2023

Summary of changes

lefthook runs commands for git hooks.

actionlint can be found here https://github.com/rhysd/actionlint

#518
https://discord.com/channels/759513055117180999/759513055607783478/1176510854783578113

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@marcus-sa marcus-sa force-pushed the feat/prettier-commitlint-lefthook branch from a1100c0 to a6831e3 Compare December 12, 2023 11:56
@marcus-sa marcus-sa force-pushed the feat/prettier-commitlint-lefthook branch from a6831e3 to 2a70ca6 Compare December 12, 2023 12:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29a1a17) 77.77% compared to head (3424b8b) 77.77%.

❗ Current head 3424b8b differs from pull request most recent head 986001a. Consider uploading reports for the commit 986001a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files         188      188           
  Lines       20091    20091           
  Branches     5202     5202           
=======================================
  Hits        15625    15625           
  Misses       4466     4466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcj marcj merged commit 2225215 into deepkit:master Jan 17, 2024
@marcj
Copy link
Member

marcj commented Jan 17, 2024

thanks @marcus-sa !

@timvandam
Copy link
Contributor

Prettier 🙌🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants