Skip to content

docs: fix mocha example #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2019
Merged

docs: fix mocha example #1687

merged 7 commits into from
Jul 9, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 8, 2019

Removed grunt and used Karma instead. Also updated Jasmine README as it wasn't using grunt anymore either.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Stephen

@straker straker requested a review from a team as a code owner July 8, 2019 21:41
@straker straker changed the title tests: fix failing mocha example tests: fix mocha example Jul 9, 2019
@straker straker changed the title tests: fix mocha example docs: fix mocha example Jul 9, 2019
@straker straker merged commit de06cd2 into develop Jul 9, 2019
@straker straker deleted the fixMochaExample branch July 9, 2019 14:55
WilcoFiers pushed a commit that referenced this pull request Jul 22, 2019
* docs: fix broken mocha example

* update readme

* update package.json

* revert test-examples.js

* sync test-examples code to understand output

* rerevert test-examples.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants