Skip to content

Add mpriscella/features to collection index #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

mpriscella
Copy link
Contributor

Adds https://github.com/mpriscella/features to the collection index.

I couldn't find any guidance on submitting a personal collection of features, but figured it was worth the PR. These are features to add a series of command line tools that I've found useful professionally and personally.

If a personal collection is inappropriate for this, please let me know and I'll find an alternate solution.

@mpriscella mpriscella requested a review from a team as a code owner October 13, 2022 17:41
@craiglpeters
Copy link
Member

craiglpeters commented Oct 14, 2022

Hi @mpriscella great minds think alike! kubernetes-sigs/kind#2967. Maybe you can explain your use case to Ben in that issue?

Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mpriscella - We absolutely want to help surface Features from individual contributors in the community. Thanks for taking the time to opening this PR.

One thing i'll need you do to before I merge this - the ghcr.io/mpriscella/features package doesn't appear to be public (I don't see it when navigating to https://github.com/mpriscella?tab=packages&repo_name=features in a private browser)

Once you mark that "metadata" package as public, we will be able to crawl the Features and add to our index

@mpriscella
Copy link
Contributor Author

Hi @joshspicer, thanks for the feedback! I wasn't aware that package was for metadata and I've just changed the visibility to public.

@craiglpeters Awesome! I'd be happy to respond to Ben in that issue.

@joshspicer joshspicer merged commit 4947f2c into devcontainers:gh-pages Oct 14, 2022
@mpriscella mpriscella deleted the mpriscella-features branch October 14, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants