fix: query string is incorrectly serialized for primitive parameters (#103) #109
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { getParameters as createGetParameters } from '../operation-object'; | ||
| import { constant } from 'fp-ts/lib/function'; | ||
| import { left } from 'fp-ts/lib/Either'; | ||
| import { fromString } from '../../../../../utils/ref'; | ||
| import { PathItemObjectCodec } from '../../../../../schema/3.0/path-item-object'; | ||
| import { pipe } from 'fp-ts/lib/pipeable'; | ||
| import { either, option } from 'fp-ts'; | ||
| import { OperationObjectCodec } from '../../../../../schema/3.0/operation-object'; | ||
| import { sequenceTEither } from '@devexperts/utils/dist/adt/either.utils'; | ||
|
|
||
| describe('OperationObject', () => { | ||
| describe('getParameters', () => { | ||
| const getParameters = createGetParameters({ | ||
| resolveRef: constant(left(new Error('Refs not supported'))), | ||
| }); | ||
|
|
||
| it('should correctly handle primitive query parameters', () => { | ||
| const operation = pipe( | ||
| OperationObjectCodec.decode({ | ||
| responses: {}, | ||
| parameters: [ | ||
| { | ||
| in: 'query', | ||
| name: 'offset', | ||
| required: false, | ||
| schema: { | ||
| type: 'number', | ||
| }, | ||
| }, | ||
| { | ||
| in: 'query', | ||
| name: 'limit', | ||
| required: true, | ||
| schema: { | ||
| type: 'number', | ||
| }, | ||
| }, | ||
| ], | ||
| }), | ||
| either.mapLeft(constant(new Error())), | ||
| ); | ||
|
|
||
| const pathItem = pipe(PathItemObjectCodec.decode({}), either.mapLeft(constant(new Error()))); | ||
|
|
||
| const result = pipe( | ||
| sequenceTEither(fromString('#/test'), operation, pathItem), | ||
| either.chain(([ref, operation, pathItem]) => getParameters(ref, operation, pathItem)), | ||
| ); | ||
|
|
||
| const generated = pipe( | ||
| result, | ||
| option.fromEither, | ||
| option.chain(result => result.serializedQueryString), | ||
| option.fold(constant(''), fragment => fragment.value.replace(/\s+/g, ' ')), | ||
| ); | ||
|
|
||
| expect(generated).toEqual( | ||
| `compact([pipe( | ||
| optionFromNullable(number).encode(parameters.query.offset), | ||
| option.fromNullable, | ||
| option.chain(value => fromEither(serializePrimitiveParameter('form', 'offset', value))), | ||
| ),pipe( | ||
| number.encode(parameters.query.limit), | ||
| value => fromEither(serializePrimitiveParameter('form', 'limit', value)), | ||
| )]).join('&')` | ||
| .trim() | ||
| .replace(/\s+/g, ' '), | ||
| ); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you add
somein allswitchbranches, would it make more sense to keep this function simpler and operate on simple types and wrap its result insomeon the call site?