Support binary and text responses #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mankdev
changed the title
raveclassic
suggested changes
Dec 1, 2020
|
Hi @mankdev, thanks for the PR! We have however some concerns on the suggested implementation, especially on the part with "deep lookup". Could you please clarify in details what are you trying to suggest and how does it correlate with OA3/swagger2 specs? Thanks! |
raveclassic
added
enhancement
|
You are right, |
# Conflicts: # src/language/typescript/common/data/serialized-type.ts
raveclassic
previously approved these changes
Dec 24, 2020
|
@mankdev LGTM, but please resolve conflicts |
# Conflicts: # src/language/typescript/3.0/serializers/operation-object.ts
|
@raveclassic done |
Serg046
approved these changes
Apr 1, 2021
dramoturg
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds support for file type response using definition
{type: 'string', format: 'binary'}, it is valid for both 2.0 and 3.0 specs.I suggest treating blob data as
unknownsince it can be handled by http-client implementationAlso it extends
Requesttype with additional fieldresponseType: 'json' | 'blob' | 'text'because this information required for proper http-client implementation.For now, I've implemented only support for 2.0 spec, but if you guys ok with the approach, I will add support for 3.0.