OpenApi string field with format date has bad path in generated typescript #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raveclassic @sutarmin anything we can do to help to get this merged? |
|
Very sorry, but I don't have enough time right now for a proper review, tbh, since I'm not really familiar with this codebase and there is a lot of things for me to comprehend. @raveclassic do you think you can spend some time on review this week? |
raveclassic
suggested changes
Dec 1, 2020
There was a problem hiding this comment.
Hi @VKamotin , thanks for the PR. However this is not how the things are supposed to work. We should not work with paths by hand but use refs instead. Please take a look at how openapi-3-utils.ts or client.ts file is passed around the files.
|
Wow, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.