Skip to content

Don't build directly in the home dir #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

stuartwdouglas
Copy link
Contributor

This can cause issues with some maven plugins that will then treat everything in the home directory (including the .m2 directory) as part of the project.

Copy link
Contributor

@jduimovich jduimovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it builds succesfully.
Tested on RHTAP as a dockerfile project, change the port to match at 8081 and it also builds and deploys.

@maysunfaisal
Copy link
Contributor

@stuartwdouglas could you pls rebase, I didnt see this earlier.

@stuartwdouglas
Copy link
Contributor Author

Done

Copy link
Contributor

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on RHTAP Staging and OpenShift 4.13.0

@maysunfaisal maysunfaisal merged commit 91e3eb5 into devfile-samples:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants