Skip to content

Viewer support for deprecated devfile stacks and samples #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
Tracked by #1063
kim-tsao opened this issue Mar 20, 2023 · 9 comments · Fixed by devfile/devfile-web#122
Closed
3 tasks
Tracked by #1063

Viewer support for deprecated devfile stacks and samples #1064

kim-tsao opened this issue Mar 20, 2023 · 9 comments · Fixed by devfile/devfile-web#122
Assignees
Labels
area/registry-viewer kind/user-story User story for new enhancement

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Mar 20, 2023

/kind user-story

Which area this user story is related to?

/area registry-viewer

User Story

As an devfile client, I want to be able to determine if the devfiles I'm using are currently supported or deprecated so that I can build my applications knowing that I am using an actively maintained devfile.

Approach

image

The registry viewer currently displays the tag but it doesn't do anything special with it. In order to bring attention to the deprecated devfile, we should:

  • Ensure the Deprecated tag is the first tag on the list and is displayed in a different colour
  • The tags are pulled from all devfile versions of a specific runtime which is incorrect. It should only display the tags for a specific runtime version.
  • Similarly, the tags shown on the registry viewer tiles represent tags from all runtime versions when it should only display the tags for the default devfile. This means if the default devfile is not deprecated, then the deprecated tag should not show up. Users would only see it if they click on the tile and toggle between versions.
  • Blocked by bug Fix Registry Viewer tags display #1289

Acceptance Criteria

We should implement something similar to what the Redhat Catalog has.

  • Display the Deprecated tag first always and on different color (red)
  • Add a deprecated toggle (off by default) to hide the deprecated devfiles
  • If default is deprecated the entire stack should be
@openshift-ci openshift-ci bot added the kind/user-story User story for new enhancement label Mar 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

@kim-tsao: The label(s) area/registry-viewer cannot be applied, because the repository doesn't have them.

In response to this:

/kind user-story

Which area this user story is related to?

/area registry-viewer

User Story

As an devfile client, I want to be able to determine if the devfiles I'm using are currently supported or deprecated so that I can build my applications knowing that I am using an actively maintained devfile.

Acceptance Criteria

We should implement something similar to what the Redhat Catalog has.

  • Display the deprecated tag in the tile
  • Add a deprecated toggle (off by default) to hide the deprecated devfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jun 19, 2023
@kim-tsao kim-tsao removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jul 20, 2023
@michael-valdron michael-valdron moved this to Backlog in Devfile Project Jul 27, 2023
@michael-valdron
Copy link
Member

michael-valdron commented Aug 3, 2023

tied to #1065, might be a possible epic

@thepetk
Copy link
Contributor

thepetk commented Aug 4, 2023

Blocked by #1065 as it has to be completed before starting this one

@michael-valdron
Copy link
Member

Blocked by #1065 as it has to be completed before starting this one

Blocked by #1065 #959 as it has to be completed before starting this one

@thepetk
Copy link
Contributor

thepetk commented Nov 20, 2023

@kim-tsao we have updated the viewer behavior and atm we are:

  • Adding a different (red) color to the Deprecated label
  • The viewer has been fixed and now we show tags per version.

Should we update the current issue only for the prioritization of the Deprecated label, which I think is also a potential good first issue?

@thepetk
Copy link
Contributor

thepetk commented Nov 20, 2023

Blocked by #1065 as it has to be completed before starting this one

Blocked by #1065 #959 as it has to be completed before starting this one

@michael-valdron I was wondering if the #959 is a blocker or maybe it is better to create a toggle only on the viewer side. More detailed:

  • The viewer will have to take all the samples and stacks with one call to the registry API.
  • After the first call the viewer will have all the required information (which is also the case right now) so it can just filter out the deprecated stacks by default.

@thepetk thepetk moved this from Waiting to Refinement in Devfile Project Jan 25, 2024
@thepetk
Copy link
Contributor

thepetk commented Jan 25, 2024

Removed blocked as the bug issue has been fixed

@thepetk
Copy link
Contributor

thepetk commented Jan 25, 2024

The only two items remaining to be done for this issue are:

  1. Display the Deprecated tag first always and on different color (red)
  2. Add a deprecated toggle (off by default) to hide the deprecated devfiles

@thepetk thepetk self-assigned this Jan 25, 2024
@Jdubrick Jdubrick moved this from Refinement to Backlog in Devfile Project Jan 25, 2024
@thepetk thepetk moved this from Backlog to To Do 📝 in Devfile Project Apr 10, 2024
@thepetk thepetk moved this from To Do 📝 to In Progress 🚧 in Devfile Project Apr 11, 2024
@thepetk thepetk moved this from In Progress 🚧 to In Review 👀 in Devfile Project Apr 12, 2024
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry-viewer kind/user-story User story for new enhancement
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

3 participants