Skip to content

ODC support for devfile parent overrides #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks
thepetk opened this issue Nov 29, 2023 · 9 comments
Closed
4 tasks

ODC support for devfile parent overrides #1365

thepetk opened this issue Nov 29, 2023 · 9 comments
Labels
area/library Common devfile library for interacting with devfiles lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@thepetk
Copy link
Contributor

thepetk commented Nov 29, 2023

Which area/kind this issue is related to?

/area library

Issue Description

There is an issue currently in the ODC side when someone is using a devfile that includes parentOverrides.

For example, someone can try to import https://github.com/devfile-samples/devfile-sample-go-basic/tree/v2.0.0. Its devfile overrides the build component and the console cannot import it.

As a result, this issue is focusing on the support of parent overrides on the ODC (Openshift Developer Console) side.

Main reason described here

Acceptance Criteria

  • Communicate with ODC side, to pass URL + token instead of raw content to the backend.
  • Issue Update ODC's Devfile Library version #1136 should be completed and the latest library version should be pulled for ODC.
  • Update the devfile handler in ODC backend to use the URL + token instead of the raw content (here
  • Test cases for parent and kubernetes uri reference should be added.
@thepetk thepetk self-assigned this Nov 29, 2023
@openshift-ci openshift-ci bot added the area/library Common devfile library for interacting with devfiles label Nov 29, 2023
@thepetk thepetk moved this to Refinement in Devfile Project Nov 29, 2023
@yangcao77
Copy link
Contributor

https://github.com/utherp0/hacexample repo only contains inner loop definition in the devfile, ODC only supports outerloop. so the first issue in the description is invalid.

@yangcao77 yangcao77 changed the title [Spike] Investigate ODC support for devfile parent overrides [Spike] ODC support for devfile parent overrides Nov 30, 2023
@yangcao77 yangcao77 moved this from Refinement to Backlog in Devfile Project Nov 30, 2023
@yangcao77
Copy link
Contributor

ODC used to send rawcontent to us, therefore the parent reference and kubernetes uri reference won't work due to devfile not flattened.

But now library have the private repo support, we are ready to accept URL + token to parse the devfile content.

So this issue needs to:

  1. communicate with ODC team, let them to pass URL + token instead of rawcontent to backend.
  2. Update ODC's Devfile Library version #1136 should pull in the latest library for ODC
  3. update devfile handler in ODC backend to use the URL+ token instead of the rawcontent:
    https://github.com/openshift/console/blob/70a927c860c56bf63cf63f6ca2bbc87910ffdec6/pkg/devfile/handler.go#L52-L55
  4. add some test cases for parent and perhaps kubernetes uri reference.

@thepetk thepetk changed the title [Spike] ODC support for devfile parent overrides ODC support for devfile parent overrides Nov 30, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Nov 30, 2023

#1136 should pull in the latest library for ODC

@yangcao77 should we add this as a blocker?

@yangcao77
Copy link
Contributor

blocked by #1136

@thepetk
Copy link
Contributor Author

thepetk commented Nov 30, 2023

https://github.com/utherp0/hacexample repo only contains inner loop definition in the devfile, ODC only supports outerloop. so the first issue in the description is invalid.

I've updated the description!

Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Feb 29, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Feb 29, 2024

Definitely still a requirement

@thepetk thepetk removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Feb 29, 2024
@thepetk thepetk removed their assignment Mar 5, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Mar 13, 2024

Removing blocker label as the #1136 is now closed

Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 23, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Nov 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done ✅ in Devfile Project Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants