Ephemeral volumes #324
Merged
Ephemeral volumes #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add field "ephemeral" to Volume components to specify that this volume should not be persisted. This enables creating devfiles that share storage between components without having to store data in a persistent volume. Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
amisevsk
requested review from
kadel,
davidfestal,
sleshchenko and
johnmcollier
Closed
sleshchenko
approved these changes
Feb 2, 2021
sleshchenko
reviewed
Feb 2, 2021
maysunfaisal
reviewed
Feb 2, 2021
kadel
approved these changes
Feb 3, 2021
davidfestal
approved these changes
Feb 11, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, davidfestal, elsony, kadel, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is half of #319 (support for ephemeral/emptyDir volume components). These components provide a way to share storage between components -- e.g. sharing a
.m2volume between a builder container and a Java language server sidecar.Compared to #319, I've renamed the field from
persistenttoephemeral(following @davidfestal's suggestion) to support havingfalseas the default value; otherwise, we're generally required to use a boolean pointer, which is a hassle to work with.What issues does this PR fix or reference?
Fixes 1/2 of #310
Is your PR tested? Consider putting some instruction how to test your changes
N/A, spec change.