Skip to content

Cleanup printcolumns #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

amisevsk
Copy link
Contributor

@amisevsk amisevsk commented Feb 1, 2021

What does this PR do?

Removes .status.ideUrl from the DevWorkspace printcolumns. Since the addition of the Info field (.status.message), the output from kubectl get devworkspaces has become long and unweildy:

$ kubectl get dw

NAME           WORKSPACE ID                PHASE     INFO                                                          URL
theia          workspace8af91dfdf1f1417f   Running                                                                 http://workspace8af91dfdf1f1417f-theia-3100.192.168.49.2.nip.io
web-terminal   workspace32d4b43e65e64e64   Failed    Failed to install network objects required for devworkspace   

Since INFO and URL are generally mutually exclusive, it makes sense to combine the two, so that

  • If a workspace has no issues, INFO contains a message like Workspace is accessible at <url>
  • If a workspace has an issue, information about the problem is propagated to INFO.

Proposed output (example):

$ kubectl get dw

NAME           WORKSPACE ID                PHASE     INFO
theia          workspace8af91dfdf1f1417f   Running   Workspace is accessible at http://workspace8af91dfdf1f1417f-theia-3100.192.168.49.2.nip.io
web-terminal   workspace32d4b43e65e64e64   Failed    Failed to install network objects required for devworkspace   

Since the addition of .status.message, the output for `kubectl get dw`
has become unweildy -- either .status.message is populated with an error
message or .status.ideUrl is populated with the URL at which to access
the workspace. To clean this up, remove the printcolumn for
.status.ideUrl and repurpose .status.message to show the URL to the
user.

Signed-off-by: Angel Misevski <[email protected]>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, davidfestal, JPinkney, sleshchenko
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants