Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata icon desc #460

Merged
merged 1 commit into from
May 14, 2021
Merged

Update metadata icon desc #460

merged 1 commit into from
May 14, 2021

Conversation

maysunfaisal
Copy link
Member

Signed-off-by: Maysun J Faisal [email protected]

What does this PR do?

Update the icon desc to be more specific of what is the expected icon data. Icon can be referenced by

  1. URI
  2. relative location of the icon in the project

What issues does this PR fix or reference?

Fixes #440

Is your PR tested? Consider putting some instruction how to test your changes

N/A

Docs PR

Signed-off-by: Maysun J Faisal <[email protected]>
Copy link
Contributor

@GeekArthur GeekArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented May 14, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GeekArthur, maysunfaisal, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit dc78e8b into devfile:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a better description on the metadata icon field
3 participants