Skip to content

Allow endpoints with the same targetPort if they are on the same container component #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Allow endpoints with the same targetPort if they are on the same container component #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6972b37
Allow duplicate endpoint targetPorts if they are in same container
amisevsk Apr 11, 2022
478f636
Regenerate files after updating endpoint targetport handling
amisevsk Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 42 additions & 18 deletions crds/workspace.devfile.io_devworkspaces.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4544,7 +4544,9 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within the
container component. The same port cannot be
used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -4844,7 +4846,9 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within the
container component. The same port cannot be
used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -4964,7 +4968,9 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within the
container component. The same port cannot be
used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -5362,8 +5368,10 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component. The
same port cannot be used by two different
container components.
type: integer
required:
- name
Expand Down Expand Up @@ -5665,8 +5673,10 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component. The
same port cannot be used by two different
container components.
type: integer
required:
- name
Expand Down Expand Up @@ -5799,8 +5809,10 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component. The
same port cannot be used by two different
container components.
type: integer
required:
- name
Expand Down Expand Up @@ -6298,7 +6310,9 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within
the container component. The same port cannot
be used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -6580,7 +6594,9 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within
the container component. The same port cannot
be used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -6702,7 +6718,9 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within
the container component. The same port cannot
be used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -7115,8 +7133,10 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component.
The same port cannot be used by
two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -7432,8 +7452,10 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component.
The same port cannot be used by
two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -7573,8 +7595,10 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component.
The same port cannot be used by
two different container components.
type: integer
required:
- name
Expand Down
60 changes: 42 additions & 18 deletions crds/workspace.devfile.io_devworkspaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4544,7 +4544,9 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within the
container component. The same port cannot be
used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -4847,7 +4849,9 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within the
container component. The same port cannot be
used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -4969,7 +4973,9 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within the
container component. The same port cannot be
used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -5367,8 +5373,10 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component. The
same port cannot be used by two different
container components.
type: integer
required:
- name
Expand Down Expand Up @@ -5670,8 +5678,10 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component. The
same port cannot be used by two different
container components.
type: integer
required:
- name
Expand Down Expand Up @@ -5804,8 +5814,10 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component. The
same port cannot be used by two different
container components.
type: integer
required:
- name
Expand Down Expand Up @@ -6303,7 +6315,9 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within
the container component. The same port cannot
be used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -6585,7 +6599,9 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within
the container component. The same port cannot
be used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -6707,7 +6723,9 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
description: Port number to be used within
the container component. The same port cannot
be used by two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -7120,8 +7138,10 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component.
The same port cannot be used by
two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -7437,8 +7457,10 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component.
The same port cannot be used by
two different container components.
type: integer
required:
- name
Expand Down Expand Up @@ -7578,8 +7600,10 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
description: Port number to be used
within the container component.
The same port cannot be used by
two different container components.
type: integer
required:
- name
Expand Down
Loading