-
Notifications
You must be signed in to change notification settings - Fork 64
Add field to DevWorkspace to allow customizing any pod fields in deployment. #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
411ae8d
to
2ebe99d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have approved the PR although the pods
field could be renamed as discussed in #860 (comment).
2ebe99d
to
b7f6e40
Compare
Updated field name to |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, l0rd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add field `podSpecOverride` to the DevWorkspace spec (but not Devfile or DevWorkspaceTemplate) that allows specifying arbitrary fields on any pods created for the DevWorkspace. Signed-off-by: Angel Misevski <[email protected]>
Fix potential nil error in generator if attempting to update JSON schema for a field that has the 'endpoints' property but isn't a ContainerComponent (e.g. a Pod spec). Signed-off-by: Angel Misevski <[email protected]>
Controller-gen cannot generate embedded metadata fields, resulting in those fields deserializing to empty objects. In order to embed metadata in a CRD, it is necessary to duplicate metadata fields where appropriate. See issue: kubernetes-sigs/controller-tools#385 for details Signed-off-by: Angel Misevski <[email protected]>
…ield Signed-off-by: Angel Misevski <[email protected]>
b7f6e40
to
8a26991
Compare
New changes are detected. LGTM label has been removed. |
Codecov ReportBase: 35.51% // Head: 34.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 35.51% 34.75% -0.77%
==========================================
Files 52 52
Lines 6653 6799 +146
==========================================
Hits 2363 2363
- Misses 4145 4291 +146
Partials 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What does this PR do?:
Add support for specifying overrides to pod fields in DevWorkspaces. This PR is a draft for discussion.
The added
pods
field in the DevWorkspace CRD supports all fields copy-pasted from the pod spec itself, omittingcontainers
andinitContainers
. In the future it may be worth automating the generation of this field from the pod spec directly.Containers are omitted as
container
component.This changes adds 100KB to the DevWorkspace CRDs.
Which issue(s) this PR fixes:
Closes #860
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: