Skip to content

Changed script in github workflow to relative path #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 23, 2022

Conversation

schultzp2020
Copy link
Contributor

@schultzp2020 schultzp2020 commented Sep 23, 2022

Signed-off-by: Paul Schultz [email protected]

What does this PR do?:

  • Fixes the path issue for release-devfile-schema and publish-devfile-schema actions.
  • Adds a concurrency action check. e.g. If a PR/branch is running the CI action and you make a new push to that branch, it cancels the previous CI runs and kicks off a new one.
  • Removed publish-devfile-schema from CI and created a separate action to run only on a push to the main branch.

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Base: 34.75% // Head: 34.75% // No change to project coverage 👍

Coverage data is based on head (83d17fe) compared to base (f69fa52).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   34.75%   34.75%           
=======================================
  Files          52       52           
  Lines        6799     6799           
=======================================
  Hits         2363     2363           
  Misses       4291     4291           
  Partials      145      145           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines 8 to 9
pull_request:
branches: [main]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why run on PRs?

with:
python-version: '3.9'

- name: Checkout devfile docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you rename this step, no longer called devfile docs, probably devfile-web?

@@ -33,7 +38,7 @@ jobs:
- name: Release new version on devfile-web
run: |
cd devfile-web-repo/
python devfile-web-repo/python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema api-repo/schemas/latest/devfile.json --release
python ./python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema api-repo/schemas/latest/devfile.json --release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python ./python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema api-repo/schemas/latest/devfile.json --release
python ./python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema ../api-repo/schemas/latest/devfile.json --release

should be?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed already

@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maysunfaisal, schultzp2020

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020 schultzp2020 merged commit ce66cff into devfile:main Sep 23, 2022
@schultzp2020 schultzp2020 deleted the fix-workflow branch September 23, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants