-
Notifications
You must be signed in to change notification settings - Fork 65
Changed script in github workflow to relative path #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Paul Schultz <[email protected]>
Codecov ReportBase: 34.75% // Head: 34.75% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
=======================================
Coverage 34.75% 34.75%
=======================================
Files 52 52
Lines 6799 6799
=======================================
Hits 2363 2363
Misses 4291 4291
Partials 145 145 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Paul Schultz <[email protected]>
…heck Signed-off-by: Paul Schultz <[email protected]>
Signed-off-by: Paul Schultz <[email protected]>
pull_request: | ||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but why run on PRs?
Signed-off-by: Paul Schultz <[email protected]>
with: | ||
python-version: '3.9' | ||
|
||
- name: Checkout devfile docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you rename this step, no longer called devfile docs, probably devfile-web?
Signed-off-by: Paul Schultz <[email protected]>
@@ -33,7 +38,7 @@ jobs: | |||
- name: Release new version on devfile-web | |||
run: | | |||
cd devfile-web-repo/ | |||
python devfile-web-repo/python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema api-repo/schemas/latest/devfile.json --release | |||
python ./python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema api-repo/schemas/latest/devfile.json --release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python ./python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema api-repo/schemas/latest/devfile.json --release | |
python ./python/src/api_workflow/api_workflow.py --version ${{ steps.get_version.outputs.version }} --devfile-schema ../api-repo/schemas/latest/devfile.json --release |
should be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed already
Signed-off-by: Paul Schultz <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maysunfaisal, schultzp2020 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Paul Schultz [email protected]
What does this PR do?:
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: