fix: common PVC cleanup job to be assigned to a correct node #1415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request enhances the common PVC cleanup job by adding node affinity rule.
This change modifies the cleanup job creation logic to:
volume.kubernetes.io/selected-node
annotation from the common PVC associated with the DevWorkspace.requiredDuringSchedulingIgnoredDuringExecution
node affinity rule to the cleanup job's pod spec, targeting the specified node.This ensures that the cleanup job pod runs on the same node as the volume. If the annotation is not present, no node affinity is added.
What issues does this PR fix or reference?
resolves #1269
Is it tested? How?
volume.kubernetes.io/selected-node
annotation. Note the node name specified in the annotation value.nodeSelectorTerms
target the node name noted in step 2 via thekubernetes.io/hostname
key.PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che