Finalize workspace -> devWorkspace renaming

[sleshchenko]

What does this PR do?

This PR is supposed to finalize workspace -> devWorkspace renaming but it does not do it fully.

What issues does this PR fix or reference?

It's for #321

Che Machine exec PR eclipse-che/che-machine-exec#138

Is it tested? How?

not yet.

[openshift-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[benoitf]

I think id would be enough

[sleshchenko]

it's the time to make this label shorter if we wish, but I don't think we win anything with such change, just make things less clearer.
It would be clearer if it would be devworkspace.devfile.io/name but it's controller.devfile.io/ group, and just name is not clear IMHO

Also this label is propagated to all devworkspace related stuff, pod, service, route.... It may be not clear enough to see controller.devfile.io/name label.

[sleshchenko]

devworkspaceId vs devWorkspaceId

[sleshchenko]

Agreed on DevWorkspaceId as go field, but json version is devworkspaceId

[sleshchenko]

/test v5-devworkspaces-operator-e2e

[sleshchenko]

/test v5-devworkspaces-operator-e2e

[amisevsk]

LGTM. Tested updating from main to this PR (manually) and saw no issues except from some strangeness that I think was my cluster rather than the operator.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, sleshchenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amisevsk,sleshchenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[sleshchenko]

Tested failed because I forget to rename workspace_name to devworkspace_name label.
Now it should be fine. Ran e2e against RHPDS cluster.

[sleshchenko]

Found a bug. Deployment must be recreated if selector is changed.
Otherwise workspace won't start due:

2021-04-08T11:45:29.354Z        ERROR   controller      Reconciler error        {"reconcilerGroup": "workspace.devfile.io", "reconcilerKind": "DevWorkspace", "controller": "devworkspace", "name": "spring-petclinic", "namespace": "opentlc-mgr-che", "error": "Deployment.apps \"workspace8313386c181c4e11\" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{\"controller.devfile.io/devworkspace_id\":\"workspace8313386c181c4e11\", \"controller.devfile.io/devworkspace_name\":\"spring-petclinic\"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable"}

[sleshchenko]

I tested all changed components together: DWO, DWCO, Che Theia, Che Machine Exec, Che Dashboard and it seems to work

[sleshchenko]

/test v5-devworkspaces-operator-e2e

[sleshchenko]

I tested and it works, merging but @amisevsk @JPinkney you have any comments to the last commits - let me know and I'll fix it.