Support workspace env #529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for workspaceEnv (i.e. environment variables provided by a
component that get added to all other components) though setting an
attribute 'workspaceEnv' in a component. If that component is added to
the workspace (either directly or through a plugin) the environment
variables defined within are added to all containers and init containers
in the workspace.
Example: a component
components:
- name: my-component
attributes:
workspaceEnv:
- name: MY_ENV
value: my-value
- name: MY_ENV_2
value: my-value-2
will add the MY_ENV and MY_ENV_2 environment variables to all containers
in the DevWorkspace.
Signed-off-by: Angel Misevski <[email protected]>
Extract common setup for tests to a separate function Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR is a little half-baked since GitHub submitted it while I was writing the description :/ |
Switch the definition of workspaceEnv from
attributes:
workspaceEnv:
- name: TEST_ENV_1
value: TEST_VAL_1
- name: TEST_ENV_2
value: TEST_VAL_2
to
attributes:
workspaceEnv:
TEST_ENV_1: TEST_VAL_1
TEST_ENV_2: TEST_VAL_2
Signed-off-by: Angel Misevski <[email protected]>
8 tasks
|
Needs to be reworked, will reopen once it's actually done right 😉 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for workspaceEnv as in devfile 1.0 via the attribute
workspaceEnvon components. Environment variables can be added to all containers in a DevWorkspace by specifying e.g.What issues does this PR fix or reference?
Closes #530
Is it tested? How?
Test cases are added. Can be tested directly using the DevWorkspace
PR Checklist
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-pathto trigger)v7-devworkspaces-operator-e2e: DevWorkspace e2e testv7-devworkspace-happy-path: DevWorkspace e2e test