feat: update controller runtime to v0.9.5 #567
Conversation
Prep code for supporting k8s 1.21: * Add context.Context parameter to Reconcile() functions [1] * Add RBAC get/create/update coordination.k8s.io/v1 Leases (replacing a configmap for leader election locks) [2] * Adapt event handler code to reflect simplification [3] * Adapt to apimachinery/pkg/runtime Log deprecation (replaced with pkg/client Log) [4] * client.Object is preferred in favor of runtime.Object (v0.7.0 release) [5] * Use admission/v1 instead of v1beta1 for webhook requests [6] [1] - kubernetes-sigs/controller-runtime#1054 [2] - kubernetes-sigs/controller-runtime#1144 [3] - kubernetes-sigs/controller-runtime#1119 [4] - kubernetes-sigs/controller-runtime#1105 [5] - kubernetes-sigs/controller-runtime#898 kubernetes-sigs/controller-runtime#1118 [6] - kubernetes-sigs/controller-runtime#1284 kubernetes-sigs/controller-runtime@a32b29d Signed-off-by: Angel Misevski <[email protected]>
Update sigs.k8s.io/controller-runtime to version v0.9.5, and match other dependencies to those used by controller-runtime, notably: * k8s.io/api, k8s.io/apimachinery, k8s.io/client-go updated to v0.21.3 * Go version should be upgraded to 1.16 but isn't since there isn't a Go 1.16 UBI image we can use as builder. Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
|
Skipping CI for Draft Pull Request. |
JPinkney
changed the title
…r-runtime Signed-off-by: Josh Pinkney <[email protected]>
JPinkney
changed the title
|
/test v7-devworkspaces-operator-e2e |
2 similar comments
|
/test v7-devworkspaces-operator-e2e |
|
/test v7-devworkspaces-operator-e2e |
|
e2e test fails with
|
|
I expect openshift/release#21509 to fix the e2e tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test v8-devworkspaces-operator-e2e |
|
e2e test still fails with |
Signed-off-by: Josh Pinkney <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
/test v8-devworkspaces-operator-e2e |
|
@JPinkney: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test v8-devworkspaces-operator-e2e |
What does this PR do?
This PR is the rebased version of #540. I tried to avoid overriding that one just in case something messed up.
What issues does this PR fix or reference?
#516
Is it tested? How?
Not yet so I'm leaving at WIP for now
PR Checklist
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-pathto trigger)v7-devworkspaces-operator-e2e: DevWorkspace e2e testv7-devworkspace-happy-path: DevWorkspace e2e test