feat: Introduce count thresholds for unrecoverable pod events #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable more fine-grained management of unrecoverable pod events during workspace startup by having different thresholds for how many times an event can be seen before it is considered fatal. Signed-off-by: Angel Misevski <[email protected]>
ibuziuk
approved these changes
Mar 17, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds threshold count value to unrecoverable events, so that we can hopefully not fail on FailedMount events that will automatically resolve after a while.
What issues does this PR fix or reference?
Hopefully (:crossed_fingers:) fixes the various different instances #778 that pop up every now and then.
Is it tested? How?
I can't actually test this PR as I cannot reliably trigger the reported FailedMount events. Out of a hundred recent workspace starts in the dogfooding cluster, the FailedMount issue happened only 7 times.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che