-
Notifications
You must be signed in to change notification settings - Fork 32
Merge meta.yaml and devfile.yaml #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jingfu wang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GeekArthur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes need to be made in the github.com/devfile/api repo? As this json file is copied automatically from the generated json spec each time changes are merged into devfile/api
I think the changes for |
@johnmcollier https://github.com/devfile/docs/blob/master/generate-api-reference.js#L12 here is the place how this repo uses the |
@GeekArthur This CI job https://github.com/devfile/api/blob/master/.github/workflows/ci.yaml#L66 publishes the If you're adding new fields to the |
Ah, I was missing the CI part in API repo, I am gonna make the changes on API repo, thanks for pointing that out. |
The changes need to made on API repo as the API repo CI is responsible for syncing the |
Signed-off-by: jingfu wang [email protected]
Fixes devfile/api#172
This PR is used to move fields from meta.yaml to devfile.yaml in terms of documentation.