-
Notifications
You must be signed in to change notification settings - Fork 32
added more content and context to devfile resources #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added more content and context to devfile resources #41
Conversation
New commit is up. No rush to review since PRs # 43-46 take priority, given the needed schema updates. |
@neal-timpe or @Eva-Lotte would either of you mind reviewing the latest commit, addressing both of your awesome feedback? If it looks good, please comment with LGTM, thanks! |
LGTM |
New commit, "revised the description of the purpose for the repos" is up, addressing Elson's comment stated above. If I could get a dev to review and let me know if it's ready for the LGTM label, that'd be great, thanks! |
@johnmcollier or @elsony, new commit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elsony, jc-berger, johnmcollier The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #180: add links
I've added context and content to the devfile resource's page because as it is now, it does not provide much more than the rest of the docs do. If anyone has any ideas or suggestions as to what more we can add, I'd love to discuss.
Note: the Youtube link for me works on my machine, but not when I build the doc from Antora...I kept it because I wanted a second opinion if a YouTube video would even be necessary or beneficial at this stage.