Skip to content

added more content and context to devfile resources #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2021
Merged

added more content and context to devfile resources #41

merged 5 commits into from
Apr 12, 2021

Conversation

jc-berger
Copy link
Contributor

@jc-berger jc-berger commented Feb 2, 2021

Fixes #180: add links

I've added context and content to the devfile resource's page because as it is now, it does not provide much more than the rest of the docs do. If anyone has any ideas or suggestions as to what more we can add, I'd love to discuss.

Note: the Youtube link for me works on my machine, but not when I build the doc from Antora...I kept it because I wanted a second opinion if a YouTube video would even be necessary or beneficial at this stage.

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Feb 2, 2021
@jc-berger jc-berger self-assigned this Feb 2, 2021
@jc-berger
Copy link
Contributor Author

New commit is up. No rush to review since PRs # 43-46 take priority, given the needed schema updates.

@jc-berger
Copy link
Contributor Author

@neal-timpe or @Eva-Lotte would either of you mind reviewing the latest commit, addressing both of your awesome feedback? If it looks good, please comment with LGTM, thanks!

@neal-timpe
Copy link

LGTM

@jc-berger
Copy link
Contributor Author

New commit, "revised the description of the purpose for the repos" is up, addressing Elson's comment stated above. If I could get a dev to review and let me know if it's ready for the LGTM label, that'd be great, thanks!

@jc-berger
Copy link
Contributor Author

@johnmcollier or @elsony, new commit, rephrased how to view open issues, is up. Let me know if it looks good to merge now, thanks!

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jc-berger jc-berger changed the title WIP: added more content and context to devfile resources added more content and context to devfile resources Apr 8, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, jc-berger, johnmcollier

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkratky rkratky merged commit 364f205 into devfile:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relevant project links to website
7 participants