Skip to content

Modified docs to adhere to schema_3rd PR #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Modified docs to adhere to schema_3rd PR #45

merged 1 commit into from
Apr 1, 2021

Conversation

jc-berger
Copy link
Contributor

For Jira #2557.

See related GitHub issues:

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Mar 4, 2021
@jc-berger jc-berger self-assigned this Mar 4, 2021
elsony
elsony requested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove plugin from the example in proc_limiting-resources-usage.adoc given that it will no longer be supported by the spec as commented earlier.

@jc-berger
Copy link
Contributor Author

jc-berger commented Mar 23, 2021 •
edited
Loading

@maysunfaisal and/or @elsony, see the new commit and remaining conversation notes. Let me know what y'all think, thanks!

I've initiated a doc review as well, so I'll be getting some feedback on the language here soon.

elsony
elsony approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mark this approved based on the only change that I requested is to merge the two kubernetes resources page (see my comment). I am not sure if you are planning to do that in this PR or a separate one so I mark this one as approved.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, jc-berger, maysunfaisal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal self-requested a review March 24, 2021 20:24
@maysunfaisal
Copy link
Member

Didnt meant to approve this for now, was confused between this and the 2nd PR which i meant to approve 😄

@yhontyk
Copy link
Contributor

yhontyk commented Mar 25, 2021

LGTM language-wise

@jc-berger
Copy link
Contributor Author

@elsony, thanks! I think we can merge this PR, because the adding kubernetes component to a devfile will be merged in PR #43, so they'll both be merged in separate PRs as you stated.

@jc-berger jc-berger changed the title WIP: modified docs to adhere to schema_3rd PR Modified docs to adhere to schema_3rd PR Mar 25, 2021
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@jc-berger
modified docs to adhere to schema_3rd PR
52548d6 
minor tweaks to yaml and content

more content and yaml changes

modified yaml in limiting resources doc

more minor changes to grammar and word choice
@rkratky rkratky merged commit aa78965 into devfile:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkratky rkratky rkratky left review comments

@elsony elsony elsony approved these changes

@maysunfaisal maysunfaisal Awaiting requested review from maysunfaisal

Assignees

@elsony elsony

@maysunfaisal maysunfaisal

@jc-berger jc-berger

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
6 participants
@jc-berger @openshift-ci-robot @maysunfaisal @yhontyk @rkratky @elsony