Skip to content

WIP: added more assemblies to include more content on devfile registries #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: added more assemblies to include more content on devfile registries #94

wants to merge 2 commits into from

Conversation

jc-berger
Copy link
Contributor

Fixes devfile/api#82

I'll be making more PR for each new devfile registry assembly:

  1. building a custom devfile registry
  2. deploying a devfile registry
  3. registry schema

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Sep 23, 2021
@jc-berger jc-berger self-assigned this Sep 23, 2021
Copy link
Contributor

@kowen-rh kowen-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2021

@robin-owen: changing LGTM is restricted to collaborators

In response to this:

👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, robin-owen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kowen-rh
Copy link
Contributor

Actually, looking at this again, is there a reason that you include xref:deploying-devfile-registry.adoc[] in nav.adoc in this PR as opposed to #96? I noticed while reviewing #96 that it includes the actual content, but doesn't change the navigation, whereas this PR changes the navigation, but doesn't have the content. It seems oddly split.

@jc-berger
Copy link
Contributor Author

Closing this PR as all work related to devfile registry will be done in PR #99

@jc-berger jc-berger closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI-based registry support
2 participants