Skip to content

Fix index server image push issue #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

GeekArthur
Copy link
Contributor

@GeekArthur GeekArthur commented Dec 2, 2020

Signed-off-by: jingfu wang [email protected]

Please specify the area for this PR

What does does this PR do / why we need it:
This PR fix the index server image push issue.

Which issue(s) this PR fixes:

Fixes devfile/api#188

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

How to test changes / Special notes to the reviewer:

@GeekArthur GeekArthur self-assigned this Dec 2, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to ask if you had updated these.

Approving, this should fix the push issue.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GeekArthur, johnmcollier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GeekArthur,johnmcollier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@GeekArthur
Copy link
Contributor Author

I forgot to ask if you had updated these.

Approving, this should fix the push issue.

Yeah, I will keep an eye on this in the future.

@GeekArthur GeekArthur merged commit 7174e43 into devfile:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-write the OCI registry metadata container in Go
3 participants