Modify index generator validator #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jingfu wang <[email protected]>
openshift-ci
bot
added
the
approved
johnmcollier
requested changes
May 17, 2021
Sure, will add it. |
Signed-off-by: jingfu wang <[email protected]>
|
@johnmcollier I just added the test case, please review again. |
johnmcollier
approved these changes
May 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GeekArthur, johnmcollier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jingfu wang [email protected]
Please specify the area for this PR
Index generator
What does does this PR do / why we need it:
This PR modify index generator validator to restrict the number of git remotes to 1
Which issue(s) this PR fixes:
Issue from this comment: devfile/api#445 (comment)
PR acceptance criteria:
Test (WIP)
Documentation (WIP)
How to test changes / Special notes to the reviewer: