Skip to content

Check for Architecture during Registry Build #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Jul 5, 2021

Please specify the area for this PR
index/generator

What does does this PR do / why we need it:
Checks the architecture list during the registry build and outputs a warning to stdout if the architecture list is empty. Its best practice to mention the architecture when authoring devfiles but its not mandatory. Check devfile/api#244 (comment) for more info

Which issue(s) this PR fixes:

Addresses part of comment devfile/api#244 (comment)

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

How to test changes / Special notes to the reviewer:
build and run

 ./index-generator ../../tests/registry /tmp/index.json
 
the java-maven devfile has no architecture(s) mentioned
the java-quarkus devfile has no architecture(s) mentioned
the nodejs-basic devfile has no architecture(s) mentioned
the code-with-quarkus devfile has no architecture(s) mentioned
the java-springboot-basic devfile has no architecture(s) mentioned
the python-basic devfile has no architecture(s) mentioned

Index Example with Arch:

  {
    "name": "nodejs",
    "version": "1.0.0",
    "displayName": "NodeJS Runtime",
    "description": "Stack with NodeJS 12",
    "type": "stack",
    "tags": [
      "NodeJS",
      "Express",
      "ubi8"
    ],
    "architectures": [
      "amd64"
    ],
    "projectType": "nodejs",
    "language": "nodejs",
    "links": {
      "self": "devfile-catalog/nodejs:latest"
    },
    "resources": [
      "devfile.yaml"
    ],
    "starterProjects": [
      "nodejs-starter"
    ]
  },

@openshift-ci openshift-ci bot requested review from GeekArthur and johnmcollier July 5, 2021 20:31
Signed-off-by: Maysun J Faisal <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@maysunfaisal maysunfaisal merged commit 985f0fa into devfile:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants