Skip to content

Add default stack and tools review owners #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

elsony
Copy link
Contributor

@elsony elsony commented Mar 24, 2022

Signed-off-by: eyuen [email protected]

What does this PR do?:

Add default stack and tools review owners. No devfile/stack changes

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes? No

How to test changes / Special notes to the reviewer:

Invites have been sent to the Devfile Reviewers group to provide read access which is required for the reviewer.

@elsony elsony requested a review from kadel March 24, 2022 17:49
@kadel
Copy link
Member

kadel commented Mar 25, 2022

If I'm not mistaken this repo is already using OpenShift's Prow.
It might be better to use Prow OWNERS file. It will allow us to have owners and reviewers of individual stakcs that will be able to approve PR without requiring them to have a write access to the whole repository.

@elsony
Copy link
Contributor Author

elsony commented Mar 25, 2022

Switched to use OWNERS file

@elsony
Copy link
Contributor Author

elsony commented Mar 25, 2022

/retest

1 similar comment
@elsony
Copy link
Contributor Author

elsony commented Apr 5, 2022

/retest

@elsony
Copy link
Contributor Author

elsony commented Apr 6, 2022

@kadel I have moved to use OWNERS file. Please review again.

@kadel
Copy link
Member

kadel commented Apr 7, 2022

@kadel I have moved to use OWNERS file. Please review again.

Some of the reviews needs to be invited to the github org

  • Christoph
  • tmds
  • BethGriggs
  • rohitkrai03

@elsony
Copy link
Contributor Author

elsony commented Apr 7, 2022

Some of the reviews needs to be invited to the github org

  • Christoph
  • tmds
  • BethGriggs
  • rohitkrai03

Invite has been sent. Waiting for them to accept.

@kadel
Copy link
Member

kadel commented Apr 13, 2022

/verify-owners

@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2022

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the devfile org. You can then trigger verification by writing /verify-owners in a comment.

  • Christoph
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • stacks/OWNERS
  • tmds
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • stacks/dotnet60/OWNERS
    • stacks/dotnetcore31/OWNERS

@elsony elsony force-pushed the main branch 2 times, most recently from 67388f3 to f1407a0 Compare April 28, 2022 21:21
@elsony
Copy link
Contributor Author

elsony commented Apr 28, 2022

/verify-owners

@elsony
Copy link
Contributor Author

elsony commented Apr 28, 2022

/retest

@elsony
Copy link
Contributor Author

elsony commented Apr 28, 2022

@kadel I have fixed the owners list so all owner ids are valid now.

@elsony
Copy link
Contributor Author

elsony commented Apr 29, 2022

/retest

1 similar comment
@elsony
Copy link
Contributor Author

elsony commented Apr 29, 2022

/retest

@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, maysunfaisal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elsony elsony merged commit 7ec465e into devfile:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants