-
Notifications
You must be signed in to change notification settings - Fork 93
Add default stack and tools review owners #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If I'm not mistaken this repo is already using OpenShift's Prow. |
Switched to use OWNERS file |
/retest |
1 similar comment
/retest |
@kadel I have moved to use OWNERS file. Please review again. |
Some of the reviews needs to be invited to the github org
|
Invite has been sent. Waiting for them to accept. |
/verify-owners |
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the devfile org. You can then trigger verification by writing
|
67388f3
to
f1407a0
Compare
Signed-off-by: eyuen <[email protected]>
/verify-owners |
/retest |
@kadel I have fixed the owners list so all owner ids are valid now. |
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elsony, maysunfaisal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: eyuen [email protected]
What does this PR do?:
Add default stack and tools review owners. No devfile/stack changes
Which issue(s) this PR fixes:
Link to github issue(s)
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes? No
How to test changes / Special notes to the reviewer:
Invites have been sent to the Devfile Reviewers group to provide read access which is required for the reviewer.