Updated base images #114
Updated base images #114
Conversation
Signed-off-by: Paul Schultz <[email protected]>
Signed-off-by: Paul Schultz <[email protected]>
|
New changes are detected. LGTM label has been removed. |
stacks/nodejs-svelte/devfile.yaml
Outdated
| @@ -25,20 +25,20 @@ components: | |||
| endpoints: | |||
| - name: http | |||
| targetPort: 5000 | |||
| image: node:lts-slim | |||
| image: rhel8/nodejs-16:latest | |||
There was a problem hiding this comment.
I think you meant registry.redhat.io/rhel8/nodejs-16. Images without a registry server specified generally default to docker.io on most Kubernetes distributions
Either way, we can't use this image. Images on registry.redhat.io require licenses (and therefore authentication) to pull, which means we can't use it.
There was a problem hiding this comment.
Yeah I just realized that I used RHEL8 instead of UBI8
stacks/python/devfile.yaml
Outdated
| @@ -16,14 +16,14 @@ starterProjects: | |||
| components: | |||
| - name: py-web | |||
| container: | |||
| image: quay.io/eclipse/che-python-3.7:nightly | |||
| image: ubi9/python-39:latest | |||
There was a problem hiding this comment.
Likewise, this image doesn't exist either. You need to specify the full registry server in the image: registry.access.redhat.com/ubi9/python-39:latest
Signed-off-by: Paul Schultz <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, schultzp2020 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Paul Schultz <[email protected]>
Signed-off-by: Paul Schultz [email protected]
What does this PR do?:
Updates the base images to a mirrored official image on quay from dockerhub.
Which issue(s) this PR fixes:
fixes devfile/api#862
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: