-
Notifications
You must be signed in to change notification settings - Fork 93
Remove .NET version number from template. #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @tmds. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This sample originates from the .Net 60 stack: https://registry.devfile.io/viewer/devfiles/Community+dotnet60 ODC currently only uses the samples for the public registry query since it currently supports the outer-loop function. The devfile 2.2 with outer-loop support will be GA very soon and the existing devfile stacks will start to support devfile 2.2 that ODC can consume. ODC will start moving to use the starter projects of the stacks instead of just using samples. By that time, you'll see multiple .Net entries with different versions of .Net samples from the registry. Therefore, having the .Net version as part of the name will be consistent with the future sample list. I would recommend keeping it as is. |
Our experience is that providing samples for different version of .NET gives you a maintenance cost of keeping them in sync with the .NET life cycle (https://access.redhat.com/support/policy/updates/net-core). The lowest maintenance cost comes from having a single sample that targets the latest LTS release. You only need to update the sample when new LTS becomes available. |
Adding @kadel to the discussion who provided different versions of the .Net stacks |
this was done like this because, at the time, there was no other way to have multiple versions of one stack.
We need to reduce maintenance costs, we are already struggling to keep Devfiles stacks up to date. @elsony I'm not sure what our depreciation policy is regarding EOL products. .NET 5.0 reached End Of Life on May 2022 (devfile/api#964 could help with that) We could simply copy |
The CI fail seems unrelated, it's about |
You should think about whether you want to make separate git repositories for these .NET versions, or separate branches in the same repository. |
There were some issues with the tests. If you rebase your PR with the current |
/retest |
@tmds Can you rebase this PR as requested? Also, you need to sign off the commits to fulfill the DCO requirements. See the details in the DCO failure for details. |
This is consistent with the other '.NET' items in the OpenShift catalog, and the other devfiles which also don't include a version number. Signed-off-by: Tom Deseyn <[email protected]>
1955c86
to
5106fc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsony, maysunfaisal, tmds The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is consistent with the other '.NET' items in the OpenShift catalog, and the other devfiles which also don't include a version number.
@kadel ptal.