Skip to content

Remove .NET version number from template. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

tmds
Copy link
Contributor

@tmds tmds commented Oct 5, 2022

This is consistent with the other '.NET' items in the OpenShift catalog, and the other devfiles which also don't include a version number.

@kadel ptal.

@openshift-ci openshift-ci bot requested review from elsony and ibuziuk October 5, 2022 12:48
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

Hi @tmds. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnmcollier
Copy link
Member

/ok-to-test

@elsony
Copy link
Contributor

elsony commented Oct 5, 2022

This sample originates from the .Net 60 stack: https://registry.devfile.io/viewer/devfiles/Community+dotnet60
The .Net one is special and includes the version number as part of the name because it has multiple versions of the stacks in the devfile registry (see https://registry.devfile.io/viewer).

ODC currently only uses the samples for the public registry query since it currently supports the outer-loop function. The devfile 2.2 with outer-loop support will be GA very soon and the existing devfile stacks will start to support devfile 2.2 that ODC can consume. ODC will start moving to use the starter projects of the stacks instead of just using samples. By that time, you'll see multiple .Net entries with different versions of .Net samples from the registry. Therefore, having the .Net version as part of the name will be consistent with the future sample list. I would recommend keeping it as is.

@tmds
Copy link
Contributor Author

tmds commented Oct 5, 2022

Our experience is that providing samples for different version of .NET gives you a maintenance cost of keeping them in sync with the .NET life cycle (https://access.redhat.com/support/policy/updates/net-core).

The lowest maintenance cost comes from having a single sample that targets the latest LTS release.

You only need to update the sample when new LTS becomes available.
And, unlike a per-version sample, it doesn't go EOL.

@elsony
Copy link
Contributor

elsony commented Oct 5, 2022

Our experience is that providing samples for different version of .NET gives you a maintenance cost of keeping them in sync with the .NET life cycle (https://access.redhat.com/support/policy/updates/net-core).

The lowest maintenance cost comes from having a single sample that targets the latest LTS release.

You only need to update the sample when new LTS becomes available. And, unlike a per-version sample, it doesn't go EOL.

Adding @kadel to the discussion who provided different versions of the .Net stacks

@kadel
Copy link
Member

kadel commented Oct 6, 2022

This sample originates from the .Net 60 stack: https://registry.devfile.io/viewer/devfiles/Community+dotnet60
The .Net one is special and includes the version number as part of the name because it has multiple versions of the stacks in the devfile registry (see https://registry.devfile.io/viewer).

this was done like this because, at the time, there was no other way to have multiple versions of one stack.

The lowest maintenance cost comes from having a single sample that targets the latest LTS release.
You only need to update the sample when new LTS becomes available. And, unlike a per-version sample, it doesn't go EOL.

Adding @kadel to the discussion who provided different versions of the .Net stacks

We need to reduce maintenance costs, we are already struggling to keep Devfiles stacks up to date.
Keeping just one LTS version makes sense to me.

@elsony I'm not sure what our depreciation policy is regarding EOL products. .NET 5.0 reached End Of Life on May 2022 (devfile/api#964 could help with that)

We could simply copy dotnet6 to a new dotnet stack and use that stack as a main .net stack that will always be kept up-to-date with the latest .NET LTS.

@tmds
Copy link
Contributor Author

tmds commented Oct 19, 2022

The CI fail seems unrelated, it's about java-openliberty.
Is it a known issue? Can you re-trigger CI?

@tmds
Copy link
Contributor Author

tmds commented Oct 20, 2022

We could simply copy dotnet6 to a new dotnet stack and use that stack as a main .net stack that will always be kept up-to-date with the latest .NET LTS.

You should think about whether you want to make separate git repositories for these .NET versions, or separate branches in the same repository.
Our team does the latter. If you want to do the same, you should create a branch for the .NET 6 example, and add the branch name to the extraDevfileEntries.yaml file.

@kadel
Copy link
Member

kadel commented Oct 24, 2022

The CI fail seems unrelated, it's about java-openliberty.
Is it a known issue? Can you re-trigger CI?

There were some issues with the tests. If you rebase your PR with the current main branch it should fix it.

@elsony
Copy link
Contributor

elsony commented Oct 31, 2022

/retest

@elsony
Copy link
Contributor

elsony commented Nov 2, 2022

There were some issues with the tests. If you rebase your PR with the current main branch it should fix it.

@tmds Can you rebase this PR as requested? Also, you need to sign off the commits to fulfill the DCO requirements. See the details in the DCO failure for details.

This is consistent with the other '.NET' items in the OpenShift catalog,
and the other devfiles which also don't include a version number.

Signed-off-by: Tom Deseyn <[email protected]>
@tmds tmds force-pushed the no_dotnet_version branch from 1955c86 to 5106fc8 Compare November 9, 2022 12:54
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Looks good to me approved labels Nov 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsony, maysunfaisal, tmds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit d25e182 into devfile:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants