Skip to content

Add a 2.2.2 devfile version and set https endpoint to Python stack #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Apr 10, 2024

What does this PR do?:

Add a 2.2.2 devfile version and set https endpoint to Python stack

Which issue(s) this PR fixes:

  1. outdated "schemaVersion" attribute
  2. "Application not found" error when launch Python application using Dev Spaces 3.12.0 / Eclipse Che Next

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

  1. Open Python 2.1.0 devfile URL https://workspaces.openshift.com/#https://raw.githubusercontent.com/dmytro-ndp/registry/54b174151d16898ae07a380ef774ad46b5ad7196/stacks/python/2.1.0/devfile.yaml
  2. Run terminal task devfile: pip-install-requirements after workspace has started.
  3. Run terminal task devfile: run-app and open application in new tab.
  4. Stop application.
  5. Run terminal task devfile: debug-py and open application in new tab.

Repeat steps above with Python 3.0.0 devfile URL https://workspaces.openshift.com/#https://raw.githubusercontent.com/dmytro-ndp/registry/54b174151d16898ae07a380ef774ad46b5ad7196/stacks/python/3.0.0/devfile.yaml

@dmytro-ndp dmytro-ndp requested a review from a team as a code owner April 10, 2024 13:44
@openshift-ci openshift-ci bot requested review from elsony and maysunfaisal April 10, 2024 13:44
Copy link

openshift-ci bot commented Apr 10, 2024

Hi @dmytro-ndp. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a new stack for these changes as an update to the schema version is a significant update. It would be best to create 2.2.0 and 3.1.0 stacks for this. Additionally, these new stacks will have to be added to https://github.com/devfile/registry/blob/main/stacks/python/stack.yaml

cc @thepetk @michael-valdron

@dmytro-ndp
Copy link
Contributor Author

@Jdubrick : thank you for review!

I have applied your suggestion from the comment above.

Signed-off-by: Dmytro Nochevnov <[email protected]>
@johnmcollier
Copy link
Member

/ok-to-test

@dmytro-ndp
Copy link
Contributor Author

dmytro-ndp commented Apr 12, 2024

@johnmcollier : repository's tests seem to have passed.
Is there anything else I should do to get this PR merged?

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 12, 2024
Copy link

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmytro-ndp, Jdubrick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants