-
Notifications
You must be signed in to change notification settings - Fork 93
Add a 2.2.2 devfile version and set https endpoint to Python stack #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dmytro Nochevnov <[email protected]>
Hi @dmytro-ndp. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should create a new stack for these changes as an update to the schema version is a significant update. It would be best to create 2.2.0
and 3.1.0
stacks for this. Additionally, these new stacks will have to be added to https://github.com/devfile/registry/blob/main/stacks/python/stack.yaml
dac1b6d
to
2a6a526
Compare
@Jdubrick : thank you for review! I have applied your suggestion from the comment above. |
Signed-off-by: Dmytro Nochevnov <[email protected]>
/ok-to-test |
@johnmcollier : repository's tests seem to have passed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmytro-ndp, Jdubrick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What does this PR do?:
Add a 2.2.2 devfile version and set https endpoint to Python stack
Which issue(s) this PR fixes:
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
devfile: pip-install-requirements
after workspace has started.devfile: run-app
and open application in new tab.devfile: debug-py
and open application in new tab.Repeat steps above with Python 3.0.0 devfile URL https://workspaces.openshift.com/#https://raw.githubusercontent.com/dmytro-ndp/registry/54b174151d16898ae07a380ef774ad46b5ad7196/stacks/python/3.0.0/devfile.yaml