update all stacks to use $PROJECT_SOURCE

[kadel]

WORK IN PROGRESS

$PROJECT_SOURCE should be used and not $PROJECTS_ROOT

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

• Contributing guide
  Have you read the devfile registry contributing guide and followed its instructions?
• Test automation
  Does this repository's tests pass with your changes?
• Documentation
  Does any documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

[kadel]

/retest

[kadel]

java-quarkus test is failing, but that has nothing to do with this PR.
It fails to start application on

[ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:2.7.1.Final:dev (default-cli) on project code-with-quarkus: Detected Maven Version (3.6.2)  is not supported, it must be in [3.8.1,). -> [Help 1]

It looks like the starter project is incompatible with the image being used in devfile

reported quarkus issue in devfile/api#773

[openshift-ci]

@kadel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.7-registry-test	2554488	link	true	/test v4.7-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kadel]

@elsony @l0rd can you please review this? This is trying to address one of the items in Che/odo devfile compatibility devfile/api#679

[l0rd]

LGTM with one note:

workingDir: ${PROJECT_SOURCE}

may be omitted as in the meantime, at least for Che, it has become the default: if workingDir is not specified we set it to ${PROJECT_SOURCE}.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadel, l0rd

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elsony]

java-quarkus test is failing, but that has nothing to do with this PR.

This is a known problem and we have already opened a bug to track it: quarkusio/quarkus#23562

[kadel]

may be omitted as in the meantime, at least for Che, it has become the default: if workingDir is not specified we set it to ${PROJECT_SOURCE}.

@l0rd The Devfile spec doesn't define any default value for this. We should not just assume ${PROJECT_SOURCE}. Odo in this case just uses the working directory as specified in the image.

${PROJECT_SOURCE} is a sensible default, but if we want that we should specify it in the devfile API spec.

[l0rd]

yes, that's what I meant: if we agree on that we could specify it in the spec and update the registry.