-
Notifications
You must be signed in to change notification settings - Fork 93
add missing DEBUG_PORT env variable #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomas Kral <[email protected]>
java-quarkus is failing due to devfile/api#773 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does setting the debug port to the same port means we are increasing the chances of getting port conflict when running different types of applications at the same time? It is fairly common in tools, e.g. IDE, to have configurable debug port numbers, usually auto-generated. Do we need a debug port to explicitly set in every devfile?
If we don't set it in the devfile then the tools will have to set it themself. I don't think that this can create conflicts. Each devfile runs as a separate Deployment/Port/Container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elsony, kadel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What does this PR do?:
Debug commands are using
DEBUG_PORT
variable but that variable is not defined in containers.This was not an issue for
odo
as it automatically injects this variable if it is not defined, but this creates problems for other tools.Which issue(s) this PR fixes:
fixes one of the items in devfile/api#679
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?