Skip to content

add missing DEBUG_PORT env variable #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

kadel
Copy link
Member

@kadel kadel commented Feb 15, 2022

What does this PR do?:

Debug commands are using DEBUG_PORT variable but that variable is not defined in containers.
This was not an issue for odo as it automatically injects this variable if it is not defined, but this creates problems for other tools.

Which issue(s) this PR fixes:

fixes one of the items in devfile/api#679

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?

@kadel
Copy link
Member Author

kadel commented Feb 15, 2022

java-quarkus is failing due to devfile/api#773

@elsony
Copy link
Contributor

elsony commented Feb 24, 2022

/retest

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does setting the debug port to the same port means we are increasing the chances of getting port conflict when running different types of applications at the same time? It is fairly common in tools, e.g. IDE, to have configurable debug port numbers, usually auto-generated. Do we need a debug port to explicitly set in every devfile?

@kadel
Copy link
Member Author

kadel commented Feb 28, 2022

Does setting the debug port to the same port means we are increasing the chances of getting port conflict when running different types of applications at the same time? It is fairly common in tools, e.g. IDE, to have configurable debug port numbers, usually auto-generated. Do we need a debug port to explicitly set in every devfile?

If we don't set it in the devfile then the tools will have to set it themself.
Currently, there is nothing in devfile spec that defines that tools should set this variable.
Odo sets it if it is not defined in the devfile, but Che doesn't so without setting it explicitly in devfile debug in Che won't work (devfile/api#777)

I don't think that this can create conflicts. Each devfile runs as a separate Deployment/Port/Container.

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Feb 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, kadel

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants