Fix Python 3.5 support not displayed in badge #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoxin
approved these changes
May 23, 2021
devoxin
pushed a commit
that referenced
this pull request
Oct 2, 2021
devoxin
added a commit
that referenced
this pull request
Feb 26, 2022
* Rename some errors, support Union[int, str] for user_id * Expose AuthenticationError * Ambiguous no more * Update get_tracks returns * Fix dispatching to empty hook lists * Bump aiohttp * Fix slight mistake in example cog. * Readme QoL change. * Use a link reference instead * Start on filter stuff * Update license stuff * Fix CI badge * Fix broken doc ref * Finishing up filter stuff maybe * Specify decode_errors when decoding author too * Exceptions -> Errors, more reliably pull WS close code, handle ConnectionResetError * Didn't mean to push this loool * Add utfm decoding capabilities * Fix equalizer failing to serialize * forgot an await, oops * Reorder player_manager funcs * Fix docs & expand parameter names * Update Lavalink URL * Fix Python 3.5 support not displayed in badge (#109) lol * Update example to use voice client (#116) * Update example to use voice client discord.py 2.0 removed the `on_socket_response` event. This resulted in Lavalink.py not being able to forward the events. At least in the current implementation of the example. We now use the preferred way of using the VoiceProtocol to forward the voice events to Lavalink. * Set player.channel_id to None manually * support new lavalink exception format (#105) * Bump min aiohttp version * Update copyright * who did this * Update license 2 * Making a note of this issue * Bump aiohttp upper version * Slight adjustments to strings * Expose previously unused variables 'position' and 'encoder_version' * Clarify some units in Stats.py * Logging message consistency * Remove superfluous log call in _node_disconnect * Logging consistency * Init node with empty stats object * scheisse * Redundant logic check as this will be zero anyway * int() guild_id in create, add doc link to DefaultPlayer * Doc consistency in playermanager.py * Document player.channel_id attr * More documentation updates * Finalise guild_id -> int change * Lavalink.py v4.0.0 * 0.0 is the default gain * Add timestamp_to_millis helper function. * Linting * Register auto docs for new things * Minor docs changes again * How much other stuff is missing??? * cmon * Fixing docs build error * Add filter limits, allow passing str to Player.X_filter, add filter TODOs * Fix docs formatting * Add missing list call * Avoid handling TrackStartEvent to prevent None being fired * Rotation filter * Low Pass filter * Add channelmix + lint * Add missing __ to init * Add filter command to example cog. * Lavalink appears to have exception handling for this... * Mark set_gain(s) & reset_equalizer as deprecated, add docs for remove_filter. * Enlarge deprecation warning * Move deprecation warning last to ensure func summary still works as intended * Distortion filter * Lint * New year new me xx * doc stuff * forgot to cd out of docs/ * update readme badge * Support volume filter * Enforce 0 < volume < 5 * Support connected in PlayerUpdateEvent * Linting * Small cleanups * new codacy badge * Implement DeferredAudioTrack * Linting * Imports & docs * Custom source support * Implement hash for source * Implement handling for info attribute access in AudioTrack * More docstrings, a little more consistency * Clarify docs. * Adjust player.add parameters, docs * Fix an issue with track needing to be declared, improve compatibility * Oversight * Implement two more docstrings in Client. * Custom Source provider example * If check to avoid returning bogus track on every query. * Enum documentation * missing , * self._raw in AudioTrack * slotssssssss * lets gloss over this ok * Copy-paste RIP * Fix typo in custom_source.py * Add player.destroy shortcut * Reluctantly support passing AudioTrack to AudioTrack * Don't overwrite requester * Remove AudioTrack construction from example cog * Access attributes directly in example cog * Filter descriptions. * an -> a * Support position + sourceName fields * Correctly reflect that track is Optional * Close any existing websockets before connecting * support volume + pause in play op * Fix volume not having an immediate effect * Add @lavalink.listener decorator support * Clarify listener decorator * forgot to cd out of docs again lol * Add player.update_filter, improve docs * Ensure provided filter is a class not instance * Instances passed to issubclass will throw, catch that. * subclass check in other x_filter commands * Add custom source to README * Updating readme * Reducing duplicated code in client * Fixing a slight oversight * Sorting out comment lines a little lol * Remove unused import from example/music.py * Experimental command-line tools * Support SSL on nodes * Use pythonic naming * Add clear_filters() * Only apply endTime if > 0 * On second thoughts, move endTime check AFTER sanity check Co-authored-by: AlexFlipnote <[email protected]> Co-authored-by: sh0tx420 <[email protected]> Co-authored-by: Eric Schneider <[email protected]> Co-authored-by: Rob Wainwright <[email protected]>
devoxin
added a commit
that referenced
this pull request
Aug 18, 2022
* Fix dispatching to empty hook lists * Bump version * Bump aiohttp * Update license stuff * Fix CI badge * Fix broken doc ref * support new lavalink exception format (#105) * Making a note of this issue * Bump aiohttp upper version * Bump Lavalink.py to 3.1.5 * Update dev to Lavalink.py 4.0 (#121) * Rename some errors, support Union[int, str] for user_id * Expose AuthenticationError * Ambiguous no more * Update get_tracks returns * Fix dispatching to empty hook lists * Bump aiohttp * Fix slight mistake in example cog. * Readme QoL change. * Use a link reference instead * Start on filter stuff * Update license stuff * Fix CI badge * Fix broken doc ref * Finishing up filter stuff maybe * Specify decode_errors when decoding author too * Exceptions -> Errors, more reliably pull WS close code, handle ConnectionResetError * Didn't mean to push this loool * Add utfm decoding capabilities * Fix equalizer failing to serialize * forgot an await, oops * Reorder player_manager funcs * Fix docs & expand parameter names * Update Lavalink URL * Fix Python 3.5 support not displayed in badge (#109) lol * Update example to use voice client (#116) * Update example to use voice client discord.py 2.0 removed the `on_socket_response` event. This resulted in Lavalink.py not being able to forward the events. At least in the current implementation of the example. We now use the preferred way of using the VoiceProtocol to forward the voice events to Lavalink. * Set player.channel_id to None manually * support new lavalink exception format (#105) * Bump min aiohttp version * Update copyright * who did this * Update license 2 * Making a note of this issue * Bump aiohttp upper version * Slight adjustments to strings * Expose previously unused variables 'position' and 'encoder_version' * Clarify some units in Stats.py * Logging message consistency * Remove superfluous log call in _node_disconnect * Logging consistency * Init node with empty stats object * scheisse * Redundant logic check as this will be zero anyway * int() guild_id in create, add doc link to DefaultPlayer * Doc consistency in playermanager.py * Document player.channel_id attr * More documentation updates * Finalise guild_id -> int change * Lavalink.py v4.0.0 * 0.0 is the default gain * Add timestamp_to_millis helper function. * Linting * Register auto docs for new things * Minor docs changes again * How much other stuff is missing??? * cmon * Fixing docs build error * Add filter limits, allow passing str to Player.X_filter, add filter TODOs * Fix docs formatting * Add missing list call * Avoid handling TrackStartEvent to prevent None being fired * Rotation filter * Low Pass filter * Add channelmix + lint * Add missing __ to init * Add filter command to example cog. * Lavalink appears to have exception handling for this... * Mark set_gain(s) & reset_equalizer as deprecated, add docs for remove_filter. * Enlarge deprecation warning * Move deprecation warning last to ensure func summary still works as intended * Distortion filter * Lint * New year new me xx * doc stuff * forgot to cd out of docs/ * update readme badge * Support volume filter * Enforce 0 < volume < 5 * Support connected in PlayerUpdateEvent * Linting * Small cleanups * new codacy badge * Implement DeferredAudioTrack * Linting * Imports & docs * Custom source support * Implement hash for source * Implement handling for info attribute access in AudioTrack * More docstrings, a little more consistency * Clarify docs. * Adjust player.add parameters, docs * Fix an issue with track needing to be declared, improve compatibility * Oversight * Implement two more docstrings in Client. * Custom Source provider example * If check to avoid returning bogus track on every query. * Enum documentation * missing , * self._raw in AudioTrack * slotssssssss * lets gloss over this ok * Copy-paste RIP * Fix typo in custom_source.py * Add player.destroy shortcut * Reluctantly support passing AudioTrack to AudioTrack * Don't overwrite requester * Remove AudioTrack construction from example cog * Access attributes directly in example cog * Filter descriptions. * an -> a * Support position + sourceName fields * Correctly reflect that track is Optional * Close any existing websockets before connecting * support volume + pause in play op * Fix volume not having an immediate effect * Add @lavalink.listener decorator support * Clarify listener decorator * forgot to cd out of docs again lol * Add player.update_filter, improve docs * Ensure provided filter is a class not instance * Instances passed to issubclass will throw, catch that. * subclass check in other x_filter commands * Add custom source to README * Updating readme * Reducing duplicated code in client * Fixing a slight oversight * Sorting out comment lines a little lol * Remove unused import from example/music.py * Experimental command-line tools * Support SSL on nodes * Use pythonic naming * Add clear_filters() * Only apply endTime if > 0 * On second thoughts, move endTime check AFTER sanity check Co-authored-by: AlexFlipnote <[email protected]> Co-authored-by: sh0tx420 <[email protected]> Co-authored-by: Eric Schneider <[email protected]> Co-authored-by: Rob Wainwright <[email protected]> * 3 attempts -> max_attempts_str * missing await * Attempt fix for already connected errors * Rearrange README and document custom sources * Link to Lavaplayer repo * Remove use of endpoint as guild.region is deprecated * Fixing literals * Fixing more literals * fix func reference * use voice_client for channel comparison * Make force an optional argument * Update VoiceProtocol for latest discord.py change (#123) * Implement TrackLoadFailedEvent for DAT errors * Add LoadError * Remove this * Single track looping * Experimental fix for double VU dispatching * Don't pop event, compare session IDs * Log event type received * More typings, implement repr on some models * Log the connection error if it's not handled * Switch to logginb.exception to automatically attach the exc * Refactor logging * Remove debugging line * VSC didn't save this one, either * Remove module name from log msg * Correctly label async methods as |coro| * Add plugin support (#124) * Add support for getting plugins * Doc for plugins * remove dataclass for py3.5 and return List[Plugin] * POST is not GET * changed the wrong line 👍👍👍 * repr for plugin * plugin str * cleanups * Move node-specific functions to Node.py * Fix typo in logging format * Expose Plugin in init * Support check_local in node.get_tracks * Update docs * Fix documentation for repeat & loop class attrs * Document DefaultPlayer.loop attr * Fix reconnect attempts logic * Allow returning of connect future * Node.destroy() + docs update * hello vsc save????????? * Allow enabling debug logging for specific submodules * pushed w/o linting? fatherless behaviour * should not be async * fix parameter description * Enforce minimum for lowpass * Enforce a minimum of zero instead * Actually, enforce no minimum to remain consistent with Lavalink server. * Should be fine now. * Remove async from get_filter * Update docs * Avoid logging non-existent player if event of specific type(s) * didn't end up using this lol * Improve documentation * Implement entry point for playing tracks with custom player implementations * Update play docstring * Move requester into AudioTrack.extra * Check start_time & end_time before setting self.current * Fix: return if no_replace to prevent self.current mismatch * Bug fixes in models.py (#125) * Fix bugs Corrects the requester and also fixes start_time and end_time * oops * Fixed bugs Corrected requester and also fixed start_time and end_time * Add node_unavailable() to BasePlayer, pause position clock during node unavailability * Remove misplaced abstractmethod decorator * (AudioTrack) avoid placing source in extra. * Correctly extract sourceName for AudioTracks Co-authored-by: Rob Wainwright <[email protected]> Co-authored-by: AlexFlipnote <[email protected]> Co-authored-by: sh0tx420 <[email protected]> Co-authored-by: Eric Schneider <[email protected]> Co-authored-by: Danny <[email protected]> Co-authored-by: cdwpx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lol
Checks and guidelines:
python run_tests.pyreturns no errors?Type of change