Skip to content

[keyvault] Migrate type comment to type annotation #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2022
Merged

[keyvault] Migrate type comment to type annotation #11

merged 1 commit into from
Jul 30, 2022

Conversation

SaidBySolo
Copy link

@SaidBySolo SaidBySolo commented Jul 26, 2022

Description

close #2
type comment를 type annotation으로 변경 했습니다.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@SaidBySolo SaidBySolo changed the title style: type comment to type annotation [keyvault] style: type comment to type annotation Jul 26, 2022
@SaidBySolo SaidBySolo changed the title [keyvault] style: type comment to type annotation [keyvault] style: changed type comment to type annotation Jul 26, 2022
For more information, see issue 12947 of python/mypy

close #2
@SaidBySolo SaidBySolo changed the title [keyvault] style: changed type comment to type annotation [keyvault] Migrate type comment to type annotation Jul 29, 2022
@ianychoi
Copy link
Member

Looks great!

@ianychoi
Copy link
Member

Thank you! Let's discuss how it reflects to original repo later

@ianychoi ianychoi merged commit 27d2ce6 into devrel-kr:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants