Skip to content

build: bump versions to latest #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2021
Merged

build: bump versions to latest #239

merged 4 commits into from
Nov 6, 2021

Conversation

paul58914080
Copy link
Member

@paul58914080 paul58914080 commented Nov 5, 2021

Description

  • Spring-boot: 2.5.6
  • Springdoc: 1.5.12
  • cucumber: 7.0.0
  • maven-enforcer-plugin: 3.0.0
  • junit bom: 5.8.1

Breaking changes while upgrading

Cucumber: 7.0.0

Lambda's (cucumber-java8) does not work well with the CucumberContextConfiguration in the same file. Hence had to extract it to a different class from the StepDef as suggested in as suggested in cucumber/cucumber-jvm#2413

maven-enforcer-plugin: 3.0.0

This is an issue with legacy org.springframework.roo.annotations dependency as mentioned in spring-projects/spring-data-jpa#2285 which refers to a repository which is not actually present in maven central but at https://spring-roo-repository.springsource.org/release. Since the resource of this dependency is not used this template we can as well exclude it as mentioned in spring-projects/spring-data-jpa#2347

<dependency>
  <groupId>org.springframework.boot</groupId>
  <artifactId>spring-boot-starter-data-jpa</artifactId>
  <exclusions>
    <exclusion>
      <groupId>org.springframework.roo</groupId>
      <artifactId>org.springframework.roo.annotations</artifactId>
    </exclusion>
  </exclusions>
</dependency>
<dependency>
  <groupId>org.springframework.data</groupId>
  <artifactId>spring-data-envers</artifactId>
  <exclusions>
    <exclusion>
      <groupId>org.springframework.roo</groupId>
      <artifactId>org.springframework.roo.annotations</artifactId>
    </exclusion>
  </exclusions>
</dependency>

Checklist:

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My commits follow conventional commit message guidelines

The CucumberContextConfiguration does not work well with lambda's (cucumber-java8) hence I had to extract the configuration out of the stepdef as suggested in cucumber/cucumber-jvm#2413

Signed-off-by: Paul Williams <[email protected]>
Signed-off-by: Paul Williams <[email protected]>
had to exclude org.springframework.roo.annotations as pointed with workaround spring-projects/spring-data-jpa#2285

Signed-off-by: Paul Williams <[email protected]>
@paul58914080 paul58914080 requested a review from a team as a code owner November 5, 2021 06:56
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9c52e54). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage        ?   75.67%           
  Complexity      ?       18           
=======================================
  Files           ?        9           
  Lines           ?       37           
  Branches        ?        2           
=======================================
  Hits            ?       28           
  Misses          ?        8           
  Partials        ?        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c52e54...787a0a3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 code review Code review has been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant