Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added sql migraiton for searchable key #6252

Merged
merged 2 commits into from
Jan 3, 2025
Merged

chore: added sql migraiton for searchable key #6252

merged 2 commits into from
Jan 3, 2025

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Jan 3, 2025 •
edited by vikramdevtron
Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1612

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

vikramdevtron
vikramdevtron previously approved these changes Jan 3, 2025
View reviewed changes
@vikramdevtron vikramdevtron changed the title chore: added sql migraiton for searchable key sync: added sql migraiton for searchable key Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

@vikramdevtron vikramdevtron changed the title sync: added sql migraiton for searchable key misc: added sql migraiton for searchable key Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

@vikramdevtron vikramdevtron changed the title misc: added sql migraiton for searchable key chore: added sql migraiton for searchable key Jan 3, 2025
@vikramdevtron vikramdevtron changed the title chore: added sql migraiton for searchable key chore: added sql migration for searchable key Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

nishant-d
nishant-d previously approved these changes Jan 3, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

pawan-mehta-dt
pawan-mehta-dt previously approved these changes Jan 3, 2025
View reviewed changes
@kirandevtn kirandevtn changed the title chore: added sql migration for searchable key chore: added sql migraiton for searchable key Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

@pawan-mehta-dt pawan-mehta-dt changed the title chore: added sql migraiton for searchable key misc: added sql migraiton for searchable key Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The migration files have successfully passed the criteria!!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pawan-mehta-dt pawan-mehta-dt changed the title misc: added sql migraiton for searchable key chore: added sql migraiton for searchable key Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The Migration files providede inside of the PR does not pass the criteria!!

@devtron-labs devtron-labs deleted a comment from github-actions bot Jan 3, 2025
@kartik-579 kartik-579 merged commit 3bc82c8 into main Jan 3, 2025
11 checks passed
@kartik-579 kartik-579 deleted the searchable-key-migration branch January 3, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@pawan-mehta-dt pawan-mehta-dt pawan-mehta-dt approved these changes

@nishant-d nishant-d nishant-d left review comments

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

@tayalrishabh96 tayalrishabh96 Awaiting requested review from tayalrishabh96 tayalrishabh96 is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kartik-579 @nishant-d @vikramdevtron @pawan-mehta-dt @kirandevtn