Skip to content

fix: fix for failure to trigger cd set on auto after pre-cd is success which is also on auto which got triggered after ci #6361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Feb 5, 2025

Description

This pr handles the case when cd is set on auto and pre cd is also on auto, when ci completes then pre cd is triggered but cd is not triggered automatically, here handleCDStageCompleteEvent function was not placed correctly, this pr makes this func. independent of the check that terminal state of a workflow is reached or not also contains minor comments.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1879

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


… the check that terminal state of a workflow is reached or not.. and minor comments added
Copy link

sonarqubecloud bot commented Feb 5, 2025

@prakash100198 prakash100198 merged commit a6d7385 into main Feb 5, 2025
10 of 11 checks passed
@prakash100198 prakash100198 deleted the fix-cd-stage-complete-flow-from-main branch February 5, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants