Skip to content

fix: when a helm app is managed by argocd then skip argo app update when same name ext helm app is installed #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Feb 12, 2025

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1899

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Feb 13, 2025

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15200081 Triggered PGP Private Key dafa9f2 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
15200082 Triggered PGP Private Key dafa9f2 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
7214865 Triggered PGP Private Key dafa9f2 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
15200083 Triggered PGP Private Key dafa9f2 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
15200084 Triggered PGP Private Key dafa9f2 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

@prakash100198 prakash100198 changed the title when a helm app is managed by argocd then skip app updation when same… fix: when a helm app is managed by argocd then skip argo app update when same name ext helm app is installed Feb 14, 2025
@prakash100198 prakash100198 merged commit 08fa6d6 into develop Feb 14, 2025
10 of 12 checks passed
@prakash100198 prakash100198 deleted the argo-cd-corrupt-data-fix branch February 14, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants